From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: ugdb-0.1.7.
Date: Sat, 11 Jul 2020 17:09:47 +0200 [thread overview]
Message-ID: <20200711150947._GTIMHOyOLUUQAUdUm5wk05f3EpEwohzlb9Ta_R5qFA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23520@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23520#discussion_r453203759
Comment:
It only seems to be used in `build.rs`, so I figured it would be ok. Otherwise it tries to build `libgit2` just to include commit information into the program, which doesn't even exist in the tarball. I will see if I can move to a more up to date version of `libgit2-sys`. If that doesn't work, should I include `cmake` as a build time dep and let it build `libgit2`?
next prev parent reply other threads:[~2020-07-11 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 7:58 [PR PATCH] " ericonr
2020-07-11 10:50 ` [PR REVIEW] " q66
2020-07-11 15:08 ` ericonr
2020-07-11 15:09 ` ericonr [this message]
2020-07-11 15:35 ` [PR PATCH] [Updated] " ericonr
2020-07-11 15:36 ` [PR REVIEW] " ericonr
2020-07-11 15:58 ` q66
2020-07-11 15:59 ` q66
2020-07-11 16:17 ` ericonr
2020-07-11 22:30 ` [PR PATCH] [Updated] " ericonr
2020-07-12 13:25 ` ericonr
2020-07-15 21:40 ` [PR PATCH] [Updated] " ericonr
2020-07-15 21:45 ` ericonr
2020-07-17 9:51 ` [PR PATCH] [Merged]: New package: ugdb-0.1.8 Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711150947._GTIMHOyOLUUQAUdUm5wk05f3EpEwohzlb9Ta_R5qFA@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).