Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] xbps-src: Explain python module dependencies in Manual.md
Date: Sat, 11 Jul 2020 21:55:45 +0200	[thread overview]
Message-ID: <20200711195545.pa9zlnkqM_rziCguO-sUwjNSUwRNtB4cDjG5sF3P8XA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23525@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/ahesford/void-packages pydocs
https://github.com/void-linux/void-packages/pull/23525

xbps-src: Explain python module dependencies in Manual.md
Proper handling of python module dependencies in xbps-src needs some clarification. This is a first attempt.

cc: @ericonr 

A patch file from https://github.com/void-linux/void-packages/pull/23525.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pydocs-23525.patch --]
[-- Type: text/x-diff, Size: 2005 bytes --]

From e0e84843edd9f8aec540b223e4bae65c24f8b38a Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Sat, 11 Jul 2020 13:31:58 -0400
Subject: [PATCH] xbps-src: Explain python module dependencies in Manual.md

---
 Manual.md | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Manual.md b/Manual.md
index 10082b68da5..bdfe9dffb81 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1444,9 +1444,18 @@ Python packages should be built with the `python{,2,3}-module` build style, if p
 This sets some environment variables required to allow cross compilation. Support to allow
 building a python module for multiple versions from a single template is also possible.
 
-To allow cross compilation, the `python-devel` package (for python 2.7) must be added
-to `hostmakedepends` and `makedepends`. If any other python version is also supported,
-for example python3.4, those must also be added as host and target build dependencies.
+Python packages that rely on `python-setuptools` or `python3-setuptools` should generally map
+`install_requires` dependencies in `setup.py` to `depends` in the template, and `setup_requires`
+dependencies to `hostmakedepends` in the template. If a python package includes a compiled
+extension, the `python-devel` (for python 2.7) or `python3-devel` (for python 3.X) packages should
+be added to `makedepends`, as should any python packages that also provide native libraries
+against which the extension will be linked (even if that package is also included in
+`hostmakedepends` to satisfy `setuptools`).
+
+**NB**: Python `setuptools` will attempt to use `pip` or `EasyInstall` to fetch any missing
+dependencies at build time. If you notice warnings about `EasyInstall` deprecation or python eggs
+present in `${wrksrc}/.eggs` after building the package, then those packages should be added to
+`hostmakedepends`.
 
 The following variables may influence how the python packages are built and configured
 at post-install time:

  parent reply	other threads:[~2020-07-11 19:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-11 17:34 [PR PATCH] " ahesford
2020-07-11 17:52 ` [PR REVIEW] " ericonr
2020-07-11 17:52 ` ericonr
2020-07-11 19:31 ` Chocimier
2020-07-11 19:42 ` [PR REVIEW] " ahesford
2020-07-11 19:54 ` ahesford
2020-07-11 19:55 ` ahesford [this message]
2020-07-11 19:56 ` ahesford
2020-07-11 20:11 ` [PR REVIEW] " Chocimier
2020-07-11 20:35 ` [PR PATCH] [Updated] " ahesford
2020-07-11 20:36 ` ahesford
2020-07-11 21:59 ` ahesford
2020-07-11 21:59 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200711195545.pa9zlnkqM_rziCguO-sUwjNSUwRNtB4cDjG5sF3P8XA@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).