From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: gtk+3: update to 3.24.21.
Date: Sun, 12 Jul 2020 17:36:10 +0200 [thread overview]
Message-ID: <20200712153610.uAo-K0wUQKPGxuwUw5GVQsr-CakDkvntI4lqhf2gh0U@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23530@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23530#issuecomment-657238420
Comment:
Having tried this on my system, I got:
- `pavucontrol`, without `adwaita`, doesn't have icons
- `pavucontrol`, with `adwaita` but without `librsvg`, shows the proper icons, but prints a warning about being unable to load a pixbuf from an SVG file
- `nwgbar` (from `nwg-launchers`, not yet packaged), without adwaita, doesn't have icons
- `nwgbar`, with `adwaita` but without `librsvg`, crashses with `SIGABRT` due to being unable to load pixbufs from SVG. This is likely caused by not having a fallback
Therefore, I think what we need to do depends on the themes we currently ship. Are there themes that only ship PNGs? If not, we could make `gtk+3` depend on `librsvg`, because:
```
most gtk applications need adwaita theme to work properly -> some applications crash when SVG icons exist but they can't load them -> gtk should depend on a library to load svg icons OR those applications should depend on librsvg
```
I'm in favor of solving it for `gtk+3`, because otherwise all applications will still print warnings when using PNG icons, and tracking down applications that misbehave is time consuming and error prone. Furthermore, `librsvg` is a small package compared to `gtk+3`.
next prev parent reply other threads:[~2020-07-12 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 3:53 [PR PATCH] " ahesford
2020-07-12 6:07 ` [PR PATCH] [Updated] " ahesford
2020-07-12 6:19 ` ahesford
2020-07-12 15:36 ` ericonr [this message]
2020-07-12 17:16 ` ahesford
2020-07-12 18:12 ` [PR PATCH] [Updated] [NOMERGE] " ahesford
2020-07-12 18:17 ` ahesford
2020-07-12 21:56 ` ericonr
2020-07-13 2:38 ` ahesford
2020-07-13 8:12 ` fosslinux
2020-07-15 23:54 ` ahesford
2020-07-15 23:54 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712153610.uAo-K0wUQKPGxuwUw5GVQsr-CakDkvntI4lqhf2gh0U@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).