From: newbluemoon <newbluemoon@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] ladspa-sdk: remove archs=noarch
Date: Mon, 13 Jul 2020 21:42:17 +0200 [thread overview]
Message-ID: <20200713194217.USSGD4ntlpgvCv5CKn63Fz15GE3bOz0mmthBK5kRFIg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23533@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 790 bytes --]
There is an updated pull request by newbluemoon against master on the void-packages repository
https://github.com/newbluemoon/void-packages ladspa-sdk
https://github.com/void-linux/void-packages/pull/23533
ladspa-sdk: remove archs=noarch
The main package ladspa-sdk contains only a header file, but ladspa-sdk-example-plugins and ladspa-sdk-progs subpackages contain arch dependent binaries. Trying to load a plugin fails e.g. on i686.
I think the case where the main package is `noarch`, but some subpackages aren’t isn’t covered (yet) by xbps-src without having to add every available arch to the subpackage (which wouldn’t make sense, anyway). Or is it and I just don’t see it? :)
A patch file from https://github.com/void-linux/void-packages/pull/23533.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ladspa-sdk-23533.patch --]
[-- Type: text/x-diff, Size: 1186 bytes --]
From 0f5ebb73e1f7df16f85847ab52995fc269d50e40 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Sun, 12 Jul 2020 10:02:39 +0200
Subject: [PATCH] ladspa-sdk: not all subpackages are noarch
The ladspa-sdk-example-plugins and
ladspa-sdk-progs subpackages contain
arch dependent binaries.
---
srcpkgs/ladspa-sdk/template | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/ladspa-sdk/template b/srcpkgs/ladspa-sdk/template
index 28f27fe0300..792663a5c1f 100644
--- a/srcpkgs/ladspa-sdk/template
+++ b/srcpkgs/ladspa-sdk/template
@@ -1,7 +1,7 @@
# Template file for 'ladspa-sdk'
pkgname=ladspa-sdk
version=1.15
-revision=1
+revision=2
archs=noarch
wrksrc="ladspa_sdk_${version}"
makedepends="libsndfile-progs"
@@ -36,6 +36,7 @@ ladspa-sdk-doc_package() {
ladspa-sdk-example-plugins_package() {
short_desc+=" - Example plugins"
+ archs="*"
pkg_install() {
vmkdir usr/lib/ladspa
vcopy "${wrksrc}/plugins/*.so*" usr/lib/ladspa
@@ -44,6 +45,7 @@ ladspa-sdk-example-plugins_package() {
ladspa-sdk-progs_package() {
short_desc+=" - Example programs"
+ archs="*"
pkg_install() {
vmkdir usr
vcopy ${wrksrc}/bin usr
next prev parent reply other threads:[~2020-07-13 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 8:16 [PR PATCH] " newbluemoon
2020-07-13 18:52 ` Chocimier
2020-07-13 19:42 ` newbluemoon [this message]
2020-07-13 19:45 ` ladspa-sdk: not all subpackages are noarch newbluemoon
2020-07-13 20:14 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713194217.USSGD4ntlpgvCv5CKn63Fz15GE3bOz0mmthBK5kRFIg@z \
--to=newbluemoon@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).