From: GiorgiBeriashvili <GiorgiBeriashvili@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: vscode: update to 1.47.0.
Date: Tue, 14 Jul 2020 20:23:06 +0200 [thread overview]
Message-ID: <20200714182306.2nIiMn7wyLr-Nn7aQNQ2gPY86uYzwAVs7DUq38YsRco@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23547@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
New comment by GiorgiBeriashvili on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658337668
Comment:
> The `git not found` error is due to vscode-1.47.0/build/npm/postinstall.js line 77. It can be removed with the line
>
> ```sh
> sed -i -E "/cp\.execSync\('git config pull\.rebase true'\);/d" ${XBPS_BUILDDIR}/vscode-${version}/build/npm/postinstall.js
> ```
> in the pre_build() part.
Yes, and alongside that line, I also commented out the following:
`yarn install --ignore-engines --arch=x64`
And then it built VS Code locally without errors.
I am unsure if it is correct to uncomment those lines, though...
next prev parent reply other threads:[~2020-07-14 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
2020-07-14 9:30 ` vscode: update to 1.47.0 atk
2020-07-14 18:23 ` GiorgiBeriashvili [this message]
2020-07-14 18:23 ` GiorgiBeriashvili
2020-07-14 18:26 ` ahesford
2020-07-14 18:41 ` ahesford
2020-07-14 19:02 ` GiorgiBeriashvili
2020-07-14 19:02 ` [PR PATCH] [Closed]: " GiorgiBeriashvili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714182306.2nIiMn7wyLr-Nn7aQNQ2gPY86uYzwAVs7DUq38YsRco@z \
--to=giorgiberiashvili@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).