* [PR PATCH] Update VS Code to version 1.47.0
@ 2020-07-13 18:50 GiorgiBeriashvili
2020-07-14 9:30 ` vscode: update to 1.47.0 atk
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: GiorgiBeriashvili @ 2020-07-13 18:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
There is a new pull request by GiorgiBeriashvili against master on the void-packages repository
https://github.com/GiorgiBeriashvili/void-packages patch-1
https://github.com/void-linux/void-packages/pull/23547
Update VS Code to version 1.47.0
# Description
I had to adjust some settings locally to successfully build the software on my machine (I had `git not found` and other types of errors and had to comment out some lines of the template file), but in the end, it worked.
Since I presume that the official building process will be less error prone compared to mine, I decided to make this pull request.
The software itself runs without any glaring problems.
A patch file from https://github.com/void-linux/void-packages/pull/23547.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-23547.patch --]
[-- Type: text/x-diff, Size: 1488 bytes --]
From 32033cef0b7db24795c160ed656c609019de0a53 Mon Sep 17 00:00:00 2001
From: Giorgi Beriashvili <giorgi.beriashvili@outlook.com>
Date: Mon, 13 Jul 2020 22:49:53 +0400
Subject: [PATCH] Update VS Code to version 1.47.0
# Description
I had to adjust some settings locally to successfully build the software on my machine (I had `git not found` and other types of errors and had to comment out some lines of the template file), but in the end, it worked.
Since I presume that the official building process will be less error prone compared to mine, I decided to make this pull request.
The software itself runs without any glaring problems.
---
srcpkgs/vscode/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index d870454e6f9..eacfca356bc 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,6 +1,6 @@
# Template file for 'vscode'
pkgname=vscode
-version=1.46.0
+version=1.47.0
revision=1
hostmakedepends="pkg-config python nodejs-lts-10 yarn tar"
makedepends="libxkbfile-devel libsecret-devel"
@@ -10,7 +10,7 @@ maintainer="shizonic <realtiaz@gmail.com>"
license="MIT"
homepage="https://code.visualstudio.com/"
distfiles="https://github.com/Microsoft/vscode/archive/${version}.tar.gz"
-checksum=5bf4d51773bb26a484e0063b668cba38b5f7451cb77be230fbf64fa44d498ad8
+checksum=63e70521f11ab18643261f1bf779dc1a95855ea830010ab5481caf8b58fc5fac
patch_args="-Np1"
# Due to electron
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
@ 2020-07-14 9:30 ` atk
2020-07-14 18:23 ` GiorgiBeriashvili
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: atk @ 2020-07-14 9:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 416 bytes --]
New comment by atk on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658077808
Comment:
The `git not found` error is due to vscode-1.47.0/build/npm/postinstall.js line 77. It can be removed with the line
```sh
sed -i -E "/cp\.execSync\('git config pull\.rebase true'\);/d" ${XBPS_BUILDDIR}/vscode-${version}/build/npm/postinstall.js
```
in the pre_build() part.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
2020-07-14 9:30 ` vscode: update to 1.47.0 atk
@ 2020-07-14 18:23 ` GiorgiBeriashvili
2020-07-14 18:23 ` GiorgiBeriashvili
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: GiorgiBeriashvili @ 2020-07-14 18:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
New comment by GiorgiBeriashvili on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658337668
Comment:
> The `git not found` error is due to vscode-1.47.0/build/npm/postinstall.js line 77. It can be removed with the line
>
> ```sh
> sed -i -E "/cp\.execSync\('git config pull\.rebase true'\);/d" ${XBPS_BUILDDIR}/vscode-${version}/build/npm/postinstall.js
> ```
> in the pre_build() part.
Yes, and alongside that line, I also commented out the following:
`yarn install --ignore-engines --arch=x64`
And then it built VS Code locally without errors.
I am unsure if it is correct to uncomment those lines, though...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
2020-07-14 9:30 ` vscode: update to 1.47.0 atk
2020-07-14 18:23 ` GiorgiBeriashvili
@ 2020-07-14 18:23 ` GiorgiBeriashvili
2020-07-14 18:26 ` ahesford
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: GiorgiBeriashvili @ 2020-07-14 18:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
New comment by GiorgiBeriashvili on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658337668
Comment:
> The `git not found` error is due to vscode-1.47.0/build/npm/postinstall.js line 77. It can be removed with the line
>
> ```sh
> sed -i -E "/cp\.execSync\('git config pull\.rebase true'\);/d" ${XBPS_BUILDDIR}/vscode-${version}/build/npm/postinstall.js
> ```
> in the pre_build() part.
Yes, and alongside that line, I also commented out the following:
`yarn install --ignore-engines --arch=x64`
And then it built VS Code locally without errors.
I am unsure if it is correct to comment out those lines, though...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
` (2 preceding siblings ...)
2020-07-14 18:23 ` GiorgiBeriashvili
@ 2020-07-14 18:26 ` ahesford
2020-07-14 18:41 ` ahesford
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-07-14 18:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658339527
Comment:
If you're going to patch files, do the work in `post_patch` and then use relative paths like `build/npm/postinstall.js` because you'll already be inside `${wrksrc}` for `post_patch`.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
` (3 preceding siblings ...)
2020-07-14 18:26 ` ahesford
@ 2020-07-14 18:41 ` ahesford
2020-07-14 19:02 ` GiorgiBeriashvili
2020-07-14 19:02 ` [PR PATCH] [Closed]: " GiorgiBeriashvili
6 siblings, 0 replies; 8+ messages in thread
From: ahesford @ 2020-07-14 18:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658346655
Comment:
Also, please reconcile with #23129.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
` (4 preceding siblings ...)
2020-07-14 18:41 ` ahesford
@ 2020-07-14 19:02 ` GiorgiBeriashvili
2020-07-14 19:02 ` [PR PATCH] [Closed]: " GiorgiBeriashvili
6 siblings, 0 replies; 8+ messages in thread
From: GiorgiBeriashvili @ 2020-07-14 19:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by GiorgiBeriashvili on void-packages repository
https://github.com/void-linux/void-packages/pull/23547#issuecomment-658357040
Comment:
> Also, please reconcile with #23129.
My bad, I had not seen it before. I will close this PR, then.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Closed]: vscode: update to 1.47.0.
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
` (5 preceding siblings ...)
2020-07-14 19:02 ` GiorgiBeriashvili
@ 2020-07-14 19:02 ` GiorgiBeriashvili
6 siblings, 0 replies; 8+ messages in thread
From: GiorgiBeriashvili @ 2020-07-14 19:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
There's a closed pull request on the void-packages repository
vscode: update to 1.47.0.
https://github.com/void-linux/void-packages/pull/23547
Description:
# Description
I had to adjust some settings locally to successfully build the software on my machine (I had `git not found` and other types of errors and had to comment out some lines of the template file), but in the end, it worked.
Since I presume that the official building process will be less error prone compared to mine, I decided to make this pull request.
The software itself runs without any glaring problems.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-14 19:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 18:50 [PR PATCH] Update VS Code to version 1.47.0 GiorgiBeriashvili
2020-07-14 9:30 ` vscode: update to 1.47.0 atk
2020-07-14 18:23 ` GiorgiBeriashvili
2020-07-14 18:23 ` GiorgiBeriashvili
2020-07-14 18:26 ` ahesford
2020-07-14 18:41 ` ahesford
2020-07-14 19:02 ` GiorgiBeriashvili
2020-07-14 19:02 ` [PR PATCH] [Closed]: " GiorgiBeriashvili
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).