Github messages for voidlinux
 help / color / mirror / Atom feed
From: Hoshpak <Hoshpak@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: qemu: correct installation dir for firmware's json
Date: Thu, 16 Jul 2020 19:13:22 +0200	[thread overview]
Message-ID: <20200716171322.fbW2wJW7tKmaV0MML72lZgXyrrkGtlJ4hmiMp_kvAAw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23597@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

New comment by Hoshpak on void-packages repository

https://github.com/void-linux/void-packages/pull/23597#issuecomment-659550255

Comment:
Am 16.07.20 um 17:18 schrieb Danh Doan:
> Close: #23495
> 
> ---
> @Hoshpak 

I guess it works but I don't like it much. We shouldn't apply yet
another hack just to work around that hook which creates a false
positive in this case. My preferred way to handle this would be to make
it possible to define exceptions to the hook and just install the files
in the proper directory in the first place. I will try to come up with
an alternative PR tonight.



  reply	other threads:[~2020-07-16 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16 15:18 [PR PATCH] " sgn
2020-07-16 17:13 ` Hoshpak [this message]
2020-07-16 18:35 ` [PR REVIEW] " ahesford
2020-07-17  0:28 ` sgn
2020-07-17  0:29 ` sgn
2020-07-17 10:25 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716171322.fbW2wJW7tKmaV0MML72lZgXyrrkGtlJ4hmiMp_kvAAw@z \
    --to=hoshpak@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).