From: Hoshpak <Hoshpak@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] 11-pkglint-elf-in-usrshare: allow explicit setting of exceptions
Date: Thu, 16 Jul 2020 21:20:09 +0200 [thread overview]
Message-ID: <20200716192009.h1nvXK6QR4RVnpwV2RDTTmW-QwthCelz_WfwZj06_Vc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23601@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
New comment by Hoshpak on void-packages repository
https://github.com/void-linux/void-packages/pull/23601#issuecomment-659617133
Comment:
> *@ahesford* requested changes on this pull request.
>
> I think we will always have difficulty with files that might contain spaces in
> the name, because we will not be able to distinguish a file named |File with
> spaces| in |$ignore_in_usr_share| and three separate files named |File|, |with|
> and |spaces|. Using an array instead of space-separated strings avoids this, but
> gets clumsy in the template (if we allow arrays in |ignore_in_usr_share|, why
> not for any other variables?).
I think the general consensus up to now was to keep arrays out of
xbps-src. It will make the code less portable but we use a lot of
bashims already and the general assumption is that it will be run with
bash. Personally I just dislike how arrays are handled in bash and
usually tend to rather rewrite a script in python than having to deal
with them.
> It might also be nice to support directories in |ignore_in_usr_share| so we can
> do things like |usr/share/qemu/firmware| instead of listing each file, but that
> involves a second test and a bit of thought.
In the case of qemu there are just two files which make the hook fail. I
don't know if there are packages with a lot of files which would require
exceptions though.
> |[[ ${ignore_in_usr_share} != *$(basename "$I")* ]] |
>
> to the match operator would be consistent with with match tests in the
> build-helpers.
>
> Regardless, the argument to |basename| should be quoted in case the file has
> spaces in the name.
Thanks, I changed the check as you suggested and verified that it now
works for files with spaces.
> Also, why bother stripping out |PKGDESTDIR| from |file| if we are feeding it to
> basename anyway?
Just an oversight on my part. I removed it.
next prev parent reply other threads:[~2020-07-16 19:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:46 [PR PATCH] " Hoshpak
2020-07-16 18:29 ` pullmoll
2020-07-16 18:30 ` [PR REVIEW] " ahesford
2020-07-16 19:09 ` [PR PATCH] [Updated] " Hoshpak
2020-07-16 19:18 ` Hoshpak
2020-07-16 19:20 ` Hoshpak [this message]
2020-07-16 23:28 ` [PR REVIEW] " Johnnynator
2020-07-16 23:29 ` Johnnynator
2020-07-17 10:56 ` Piraty
2020-07-20 19:27 ` [PR PATCH] [Updated] " Hoshpak
2020-07-20 19:29 ` Hoshpak
2020-07-20 19:31 ` Hoshpak
2020-07-20 19:53 ` ahesford
2020-07-22 22:07 ` Chocimier
2020-07-23 16:34 ` Hoshpak
2020-07-29 20:54 ` Chocimier
2020-07-30 15:07 ` Hoshpak
2020-08-05 20:00 ` [PR PATCH] [Updated] " Chocimier
2020-08-05 20:00 ` Chocimier
2020-08-05 20:07 ` Chocimier
2020-08-05 20:11 ` [PR PATCH] [Updated] " Chocimier
2020-08-20 17:50 ` Chocimier
2020-08-20 17:50 ` Chocimier
2020-08-20 17:53 ` Chocimier
2020-08-25 19:14 ` [PR PATCH] [Updated] " Chocimier
2020-08-25 19:19 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716192009.h1nvXK6QR4RVnpwV2RDTTmW-QwthCelz_WfwZj06_Vc@z \
--to=hoshpak@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).