Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] dracut: add EFI kernel hook
Date: Tue, 21 Jul 2020 01:06:18 +0200	[thread overview]
Message-ID: <20200720230618.sPeV5998jmdOKgznXufW32k2pRW-hTSo4XEm-Y-HLWo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22484@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22484#discussion_r457740786

Comment:
The other way of solving this would be always passing at least an empty string to the command line parameter. But it doesn't protect the user from dumb mistakes.

  parent reply	other threads:[~2020-07-20 23:06 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  0:41 [PR PATCH] " ericonr
2020-06-01  0:47 ` [PR PATCH] [Updated] " ericonr
2020-06-01  1:06 ` ericonr
2020-06-01  2:59 ` ericonr
2020-06-01  3:57 ` ericonr
2020-06-01  7:32 ` ericonr
2020-07-20  3:58 ` ericonr
2020-07-20 14:41 ` [PR PATCH] [Updated] " ericonr
2020-07-20 16:07 ` [PR REVIEW] " Duncaen
2020-07-20 16:07 ` Duncaen
2020-07-20 16:07 ` Duncaen
2020-07-20 16:16 ` sgn
2020-07-20 16:16 ` sgn
2020-07-20 16:16 ` sgn
2020-07-20 16:16 ` sgn
2020-07-20 16:16 ` sgn
2020-07-20 16:16 ` sgn
2020-07-20 16:20 ` sgn
2020-07-20 16:28 ` sgn
2020-07-20 18:17 ` ericonr
2020-07-20 18:18 ` ericonr
2020-07-20 18:23 ` ericonr
2020-07-20 18:26 ` ericonr
2020-07-20 18:26 ` ericonr
2020-07-20 18:28 ` [PR PATCH] [Updated] " ericonr
2020-07-20 23:05 ` [PR REVIEW] " ericonr
2020-07-20 23:06 ` ericonr [this message]
2020-07-20 23:32 ` ahesford
2020-07-20 23:39 ` ericonr
2020-07-20 23:43 ` ericonr
2020-07-21  0:12 ` sgn
2020-07-21  0:12 ` sgn
2020-07-21  0:16 ` sgn
2020-07-21  0:17 ` ahesford
2020-07-21  0:27 ` ericonr
2020-07-21  1:05 ` sgn
2020-07-21  1:12 ` ericonr
2020-07-21  1:21 ` ericonr
2020-07-21  1:23 ` [PR PATCH] [Updated] " ericonr
2020-07-21  1:24 ` ericonr
2020-07-27 11:56 ` sgn
2020-07-27 12:39 ` ericonr
2020-07-27 12:49 ` [PR REVIEW] " sgn
2020-07-27 12:49 ` sgn
2020-07-27 12:51 ` [PR PATCH] [Updated] " ericonr
2020-07-27 12:52 ` [PR REVIEW] " ericonr
2020-07-27 12:52 ` [PR PATCH] [Updated] " ericonr
2020-07-27 12:53 ` sgn
2020-07-27 12:54 ` sgn
2020-07-27 12:56 ` sgn
2020-07-27 12:58 ` ericonr
2020-07-27 13:04 ` sgn
2020-07-27 13:09 ` ericonr
2020-07-27 13:18 ` [PR PATCH] [Updated] " ericonr
2020-07-27 13:19 ` ericonr
2020-07-27 13:20 ` [PR PATCH] [Updated] " ericonr
2020-07-27 13:25 ` sgn
2020-07-27 13:28 ` ericonr
2020-07-27 13:29 ` ericonr
2020-07-27 13:36 ` [PR REVIEW] " ahesford
2020-07-27 13:36 ` ahesford
2021-07-07 21:24 ` jirutka
2021-07-07 21:55 ` ahesford
2021-07-07 22:47 ` jirutka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720230618.sPeV5998jmdOKgznXufW32k2pRW-hTSo4XEm-Y-HLWo@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).