Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: stepmania: update to 5.1.0-b2
Date: Thu, 23 Jul 2020 07:07:19 +0200	[thread overview]
Message-ID: <20200723050719.UUNjyrwTJwEoUxxTHz1vnJ2E5Sm40yMOMTwn5SInKCw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23747@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 3848 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23747#issuecomment-662820521

Comment:
So, @the-maldridge has to accept this beta version first. And I cleaned it up a bit and corrected some things for you:

```
diff --git a/srcpkgs/stepmania/template b/srcpkgs/stepmania/template
index b381a7f852..d5b78e5939 100644
--- a/srcpkgs/stepmania/template
+++ b/srcpkgs/stepmania/template
@@ -2,13 +2,13 @@
 pkgname=stepmania
 version=5.1.0.b2
 revision=1
+# compilation errors with musl
 archs="i686 x86_64"
-# Upstream has stated that only x86 hardware can meed the performance constraints and that musl is not supported due to interop issues with Windows
 wrksrc=${pkgname}-${version%.*}-${version##*.}
 build_style=cmake
-cmake_builddir="Build"
-hostmakedepends="nasm yasm pkg-config git"
-makedepends="libmad-devel libvorbis-devel pcre-devel libjpeg-turbo-devel alsa-lib-devel libXrandr-devel libva-devel glew-devel pulseaudio-devel"
+hostmakedepends="yasm pkg-config git"
+makedepends="libmad-devel libvorbis-devel pcre-devel libjpeg-turbo-devel
+ alsa-lib-devel libXrandr-devel libva-devel glew-devel pulseaudio-devel"
 short_desc="Advanced rhythm game"
 maintainer="Jason Manley <jason@jasondavid.tv>"
 license="MIT"
@@ -16,19 +16,19 @@ homepage="http://www.stepmania.com/"
 distfiles="https://github.com/stepmania/stepmania/archive/v${version%.*}-${version##*.}.tar.gz"
 checksum=2e311df9b661ba287b046ce377eb0b41e426b73e169841df99fc9fe2baa89310
 
-post_extract() {
-	echo ${wrksrc}
-	vsed -i 's/PULSE_FOUND/PULSEAUDIO_FOUND/g' ${wrksrc}/StepmaniaCore.cmake
+post_patch() {
+	vsed -i 's/PULSE_FOUND/PULSEAUDIO_FOUND/g' StepmaniaCore.cmake
+}
+
+post_install() {
 	for i in 16 22 24 32 36 48 64 72 96 128 192 256
 	do
-		vinstall ${wrksrc}/icons/hicolor/${i}x${i}/apps/stepmania-ssc.png 644 usr/share/icons/hicolor/${i}x${i}/apps stepmania-ssc.png
+		vinstall icons/hicolor/${i}x${i}/apps/stepmania-ssc.png 644 \
+			usr/share/icons/hicolor/${i}x${i}/apps stepmania-ssc.png
 	done
-	vinstall ${wrksrc}/stepmania.desktop 644 usr/share/applications stepmania.desktop
-}
 
-post_install() {
+	vinstall stepmania.desktop 644 usr/share/applications stepmania.desktop
 	vlicense Docs/Licenses.txt
-	mkdir -p ${DESTDIR}/usr/bin
-	cd ${DESTDIR}
-	ln -sf ../../opt/${pkgname}-${version%.*.*}/stepmania usr/bin/
+	vmkdir usr/bin
+	ln -sf ../../opt/${version%.*.*}/stepmania ${DESTDIR}/usr/bin/
 }
```

If you want, the final template looks like:

```
# Template file for 'stepmania'
pkgname=stepmania
version=5.1.0.b2
revision=1
# compilation errors with musl
archs="i686 x86_64"
wrksrc=${pkgname}-${version%.*}-${version##*.}
build_style=cmake
hostmakedepends="yasm pkg-config git"
makedepends="libmad-devel libvorbis-devel pcre-devel libjpeg-turbo-devel
 alsa-lib-devel libXrandr-devel libva-devel glew-devel pulseaudio-devel"
short_desc="Advanced rhythm game"
maintainer="Jason Manley <jason@jasondavid.tv>"
license="MIT"
homepage="http://www.stepmania.com/"
distfiles="https://github.com/stepmania/stepmania/archive/v${version%.*}-${version##*.}.tar.gz"
checksum=2e311df9b661ba287b046ce377eb0b41e426b73e169841df99fc9fe2baa89310

post_patch() {
	vsed -i 's/PULSE_FOUND/PULSEAUDIO_FOUND/g' StepmaniaCore.cmake
}

post_install() {
	for i in 16 22 24 32 36 48 64 72 96 128 192 256
	do
		vinstall icons/hicolor/${i}x${i}/apps/stepmania-ssc.png 644 \
			usr/share/icons/hicolor/${i}x${i}/apps stepmania-ssc.png
	done

	vinstall stepmania.desktop 644 usr/share/applications stepmania.desktop
	vlicense Docs/Licenses.txt
	vmkdir usr/bin
	ln -sf ../../opt/${version%.*.*}/stepmania ${DESTDIR}/usr/bin/
}
```

It's probably `nocross=yes` instead of restricting arches, but I don't have an easy way of testing that.

  parent reply	other threads:[~2020-07-23  5:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 19:46 [PR PATCH] " jason1987d
2020-07-22 19:59 ` [PR REVIEW] " ericonr
2020-07-22 19:59 ` ericonr
2020-07-22 19:59 ` ericonr
2020-07-22 19:59 ` ericonr
2020-07-22 19:59 ` ericonr
2020-07-22 20:06 ` ericonr
2020-07-22 20:06 ` ericonr
2020-07-22 20:08 ` ericonr
2020-07-22 20:18 ` ericonr
2020-07-22 20:21 ` ericonr
2020-07-23  2:31 ` [PR PATCH] [Updated] " jason1987d
2020-07-23  2:32 ` jason1987d
2020-07-23  2:34 ` jason1987d
2020-07-23  3:24 ` [PR PATCH] [Updated] " jason1987d
2020-07-23  3:32 ` jason1987d
2020-07-23  3:48 ` jason1987d
2020-07-23  4:13 ` [PR PATCH] [Updated] " jason1987d
2020-07-23  5:07 ` ericonr [this message]
2020-07-23 14:24 ` jason1987d
2020-07-23 14:25 ` jason1987d
2020-07-23 14:28 ` ericonr
2020-07-23 15:53 ` jason1987d
2020-07-23 16:02 ` [PR PATCH] [Updated] " jason1987d
2020-07-23 16:13 ` [PR REVIEW] " ericonr
2020-07-23 16:20 ` [PR PATCH] [Updated] " jason1987d
2020-07-23 16:54 ` [PR REVIEW] " jason1987d
2020-07-23 18:05 ` jason1987d
2020-07-23 19:46 ` [PR PATCH] [Updated] " jason1987d
2020-07-23 19:46 ` jason1987d
2020-07-23 20:21 ` jason1987d
2020-11-09  4:18 ` jason1987d
2020-11-09  4:18 ` jason1987d
2020-11-09 13:10 ` ericonr
2020-11-21 18:24 ` [PR PATCH] [Closed]: " jason1987d

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723050719.UUNjyrwTJwEoUxxTHz1vnJ2E5Sm40yMOMTwn5SInKCw@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).