Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Manual: move all git info to CONTRIB, explain how to use different branch in PR.
Date: Fri, 24 Jul 2020 18:34:47 +0200	[thread overview]
Message-ID: <20200724163447.MNQhD9K1DBQ_OXCHaFSy0r8sdcV2TS8q-LxE0Z0SYKs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23788@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23788#issuecomment-663625726

Comment:
Please save description of actions in order of their execution.

"Fork a repo" does not describe how to send PR.

"git push --force" paragraph should be put in "Review" chapter. New branch is way to go when usual rewriting history caused troubles. Could you add something like following?

> More powerful way to modify commits than `git commit --amend` is [`git rebase -i HEAD~9`](https://git-scm.com/docs/git-rebase#_interactive_mode). It allows to join, reorder, change description of past commits and more.
    Alternatively, you can make other branch and push it to existing PR:
        git checkout master
        git checkout -b \<attempt2>
        # do changes anew
        git push -f \<fork> \<attempt2>:\<branch of pr>

Again: having minimal description of how to share done work at end of manual looks reasonable to me.


  parent reply	other threads:[~2020-07-24 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 22:51 [PR PATCH] " ericonr
2020-07-23 22:52 ` [PR PATCH] [Updated] " ericonr
2020-07-24 16:34 ` Chocimier [this message]
2020-07-24 17:56 ` ericonr
2020-07-24 17:58 ` ericonr
2020-07-24 18:33 ` [PR REVIEW] " Chocimier
2020-07-24 18:33 ` Chocimier
2020-07-24 18:33 ` Chocimier
2020-07-24 18:34 ` Chocimier
2020-07-24 18:34 ` Chocimier
2020-07-25  0:32 ` [PR PATCH] [Updated] " ericonr
2020-07-25  0:33 ` ericonr
2020-07-25  0:34 ` ericonr
2020-08-04 16:47 ` [PR REVIEW] " Chocimier
2020-08-04 16:49 ` Chocimier
2020-08-24  4:05 ` [PR PATCH] [Closed]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724163447.MNQhD9K1DBQ_OXCHaFSy0r8sdcV2TS8q-LxE0Z0SYKs@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).