Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: armadillo: remove absolute paths form headers
Date: Mon, 27 Jul 2020 19:50:25 +0200	[thread overview]
Message-ID: <20200727175025.9i4KzsRqTcOWmkXq4iYTiaYJR_7wDlawsP-l8upqrtI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23820@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

There's a merged pull request on the void-packages repository

armadillo: remove absolute paths form headers
https://github.com/void-linux/void-packages/pull/23820

Description:
It was #define ARMA_SUPERLU_INCLUDE_DIR /usr/arm-linux-gnueabihf/usr/include/
before. Absolute paths can't match usage of same package in both
cross and native environment at same time, let alone expansion of
'linux' macro. As all headers are installed into standard location,
relative path works.
Not suitable to upstream.

      parent reply	other threads:[~2020-07-27 17:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 21:53 [PR PATCH] " Chocimier
2020-07-25  8:44 ` sgn
2020-07-27 17:49 ` [PR PATCH] [Updated] " Chocimier
2020-07-27 17:50 ` Chocimier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727175025.9i4KzsRqTcOWmkXq4iYTiaYJR_7wDlawsP-l8upqrtI@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).