Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: bash: stop vendoring patch
Date: Tue, 28 Jul 2020 01:44:58 +0200	[thread overview]
Message-ID: <20200727234458.ZMVWFqvN8Xy2YtLkDtqhv-EhkIG4J0IdoBV6bulsqtk@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23826@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23826#issuecomment-664694316

Comment:
> Looks ok. I would commit update separately form dropping patches. Can you also change to `version=5.0.018` and derive rest of variables from it?

Initially, I reluctant to derive it since it would involve bashism somewhere, and we may run with `/bin/sh` point to something else on bootstrap.

Now, I've re-read the code, I think we'll be fine since we asked for `/bin/bash` directly.

I'll change in a minute.

  parent reply	other threads:[~2020-07-27 23:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25  8:35 [PR PATCH] " sgn
2020-07-25  8:40 ` [PR PATCH] [Updated] " sgn
2020-07-25 11:06 ` sgn
2020-07-26  5:06 ` sgn
2020-07-27 18:23 ` Chocimier
2020-07-27 23:44 ` sgn [this message]
2020-07-28  0:11 ` [PR PATCH] [Updated] " sgn
2020-07-28  7:06 ` sgn
2020-07-28  7:08 ` sgn
2020-07-28  7:24 ` sgn
2020-07-29  1:56 ` fosslinux
2020-07-29  2:12 ` sgn
2020-07-29  6:35 ` fosslinux
2020-08-04  0:07 ` sgn
2020-08-04 17:03 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727234458.ZMVWFqvN8Xy2YtLkDtqhv-EhkIG4J0IdoBV6bulsqtk@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).