Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] firejail: add patch to fix firefox under firejail
@ 2020-07-08  9:10 PaperMountainStudio
  2020-07-29  8:08 ` PaperMountainStudio
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: PaperMountainStudio @ 2020-07-08  9:10 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

There is a new pull request by PaperMountainStudio against master on the void-packages repository

https://github.com/PaperMountainStudio/void-packages fix-firejail
https://github.com/void-linux/void-packages/pull/23465

firejail: add patch to fix firefox under firejail
Close: #20226

A patch file from https://github.com/void-linux/void-packages/pull/23465.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-firejail-23465.patch --]
[-- Type: text/x-diff, Size: 2181 bytes --]

From ec7a5f74204f80e28b68702bc44398726a7dad4d Mon Sep 17 00:00:00 2001
From: Paper <paper@tilde.institute>
Date: Wed, 8 Jul 2020 11:05:49 +0200
Subject: [PATCH] firejail: add patch to fix firefox under firejail

Close: #20226
---
 srcpkgs/firejail/patches/fix-firefox.patch | 21 +++++++++++++++++++++
 srcpkgs/firejail/template                  |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/firejail/patches/fix-firefox.patch

diff --git a/srcpkgs/firejail/patches/fix-firefox.patch b/srcpkgs/firejail/patches/fix-firefox.patch
new file mode 100644
index 00000000000..e6e66f221b1
--- /dev/null
+++ b/srcpkgs/firejail/patches/fix-firefox.patch
@@ -0,0 +1,21 @@
+From f62c62c436748b0e45886bef9425748000a11135 Mon Sep 17 00:00:00 2001
+From: Antz <antzz@protonmail.ch>
+Date: Mon, 20 Jan 2020 16:30:44 +0100
+Subject: [PATCH] Fix firefox (#3171)
+
+---
+ etc/whitelist-usr-share-common.inc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/etc/whitelist-usr-share-common.inc b/etc/whitelist-usr-share-common.inc
+index 322bdefe9..78b947750 100644
+--- a/etc/whitelist-usr-share-common.inc
++++ b/etc/whitelist-usr-share-common.inc
+@@ -27,6 +27,7 @@ whitelist /usr/share/hunspell
+ whitelist /usr/share/hwdata
+ whitelist /usr/share/icons
+ whitelist /usr/share/knotifications5
++whitelist /usr/share/icu
+ whitelist /usr/share/kservices5
+ whitelist /usr/share/Kvantum
+ whitelist /usr/share/kxmlgui5
diff --git a/srcpkgs/firejail/template b/srcpkgs/firejail/template
index ad59f175933..c2daaf4e4a2 100644
--- a/srcpkgs/firejail/template
+++ b/srcpkgs/firejail/template
@@ -1,7 +1,7 @@
 # Template file for 'firejail'
 pkgname=firejail
 version=0.9.62
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-apparmor"
 hostmakedepends="pkg-config"
@@ -14,6 +14,7 @@ homepage="https://firejail.wordpress.com"
 distfiles="https://github.com/netblue30/firejail/archive/${version}.tar.gz"
 checksum=fcdc73f9a329394d3d38cab0f3724ccb08d165682a4451e9798d41882a7c031b
 conf_files="/etc/firejail/* /etc/apparmor.d/local/firejail-local"
+patch_args="-Np1"
 
 if [ "$CROSS_BUILD" ]; then
 	configure_args+=" --disable-seccomp"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
@ 2020-07-29  8:08 ` PaperMountainStudio
  2020-07-29 14:30 ` ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: PaperMountainStudio @ 2020-07-29  8:08 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/23465#issuecomment-665507407

Comment:
ping maintainer @Duncaen 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
  2020-07-29  8:08 ` PaperMountainStudio
@ 2020-07-29 14:30 ` ericonr
  2020-07-29 14:37 ` PaperMountainStudio
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-07-29 14:30 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23465#issuecomment-665699672

Comment:
Is this fixed by #23916 ? If not, could it be rolled up into it?

@jnbr ?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
  2020-07-29  8:08 ` PaperMountainStudio
  2020-07-29 14:30 ` ericonr
@ 2020-07-29 14:37 ` PaperMountainStudio
  2020-07-29 14:40 ` ericonr
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: PaperMountainStudio @ 2020-07-29 14:37 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

New comment by PaperMountainStudio on void-packages repository

https://github.com/void-linux/void-packages/pull/23465#issuecomment-665703676

Comment:
New Firefox version will not solve this. Firefox started using a file which was blacklisted by firejail, so when Firefox was started under firejail, it didn't find this file and crashed. Unless Firefox stopped using the file (probably not), we still need this patch until firejail releases a new version.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
                   ` (2 preceding siblings ...)
  2020-07-29 14:37 ` PaperMountainStudio
@ 2020-07-29 14:40 ` ericonr
  2020-07-29 14:40 ` ericonr
  2020-07-29 17:00 ` [PR PATCH] [Merged]: " Duncaen
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-07-29 14:40 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23465#issuecomment-665705209

Comment:
Oh, the patch is only in firejail! Sorry. Then yeah, this PR should stay by itself.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
                   ` (3 preceding siblings ...)
  2020-07-29 14:40 ` ericonr
@ 2020-07-29 14:40 ` ericonr
  2020-07-29 17:00 ` [PR PATCH] [Merged]: " Duncaen
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-07-29 14:40 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23465#issuecomment-665699672

Comment:
Is this fixed by #23916 ? ~~If not, could it be rolled up into it?~~

~~@jnbr ?~~

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: firejail: add patch to fix firefox under firejail
  2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
                   ` (4 preceding siblings ...)
  2020-07-29 14:40 ` ericonr
@ 2020-07-29 17:00 ` Duncaen
  5 siblings, 0 replies; 7+ messages in thread
From: Duncaen @ 2020-07-29 17:00 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

There's a merged pull request on the void-packages repository

firejail: add patch to fix firefox under firejail
https://github.com/void-linux/void-packages/pull/23465

Description:
Close: #20226

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08  9:10 [PR PATCH] firejail: add patch to fix firefox under firejail PaperMountainStudio
2020-07-29  8:08 ` PaperMountainStudio
2020-07-29 14:30 ` ericonr
2020-07-29 14:37 ` PaperMountainStudio
2020-07-29 14:40 ` ericonr
2020-07-29 14:40 ` ericonr
2020-07-29 17:00 ` [PR PATCH] [Merged]: " Duncaen

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git