[PR PATCH] perl-module: add perl to build depends

[PR PATCH] perl-module: add perl to build depends

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

There is a new pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages perl-module
https://github.com/void-linux/void-packages/pull/23942

perl-module: add perl to build depends
There are 456 packages with a build style of `perl-module`. Of those 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.

A patch file from https://github.com/void-linux/void-packages/pull/23942.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-module-23942.patch --]
[-- Type: text/x-diff, Size: 635 bytes --]

From 023f6f75086cd8564001affc64744d54a072a300 Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Wed, 29 Jul 2020 22:58:23 -0500
Subject: [PATCH] perl-module: add perl to build depends

---
 common/environment/build-style/perl-module.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/environment/build-style/perl-module.sh b/common/environment/build-style/perl-module.sh
index 2444d3d104f..60d67713147 100644
--- a/common/environment/build-style/perl-module.sh
+++ b/common/environment/build-style/perl-module.sh
@@ -1 +1,3 @@
+hostmakedepends+=" perl"
+makedepends+=" perl"
 lib32disabled=yes

Re: perl-module: add perl to build depends

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666096695

Comment:
I've made some changes to templates in how dependencies are pulled in, and didn't revbump those, only the packages that would actually change, so you wouldn't need to trigger a rebuild of 455 packages. I think it makes more sense to make this change for all templates in this PR, otherwise you will need to add an xlint for it or most packages won't be cleaned up...

Might be nice to add a note in the manual that the `perl-module` build style pulls in perl by itself too.

Re: perl-module: add perl to build depends

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666097023

Comment:
Might make sense to wait for an ok for this change before going to all the trouble, of course. And perhaps have the change as a single commit? "tree-wide: ..."

Re: perl-module: add perl to build depends

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666100003

Comment:
> I've made some changes to templates in how dependencies are pulled in, and didn't revbump those, only the packages that would actually change, so you wouldn't need to trigger a rebuild of 455 packages. I think it makes more sense to make this change for all templates in this PR, otherwise you will need to add an xlint for it or most packages won't be cleaned up...
> 
> Might be nice to add a note in the manual that the `perl-module` build style pulls in perl by itself too.

That's a good point about `xlint`. I can look at adding a rule there to warn about perl being explicitly set in makedepends/hostmakedepends.

Re: perl-module: add perl to build depends

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666101199

Comment:
> I like the idea. It could also add `perl` to `depends`.

That seems reasonable - there are three other build styles that do it as well. 

```
$ grep "^depends+" *
gem.sh:depends+=" ruby"
R-cran.sh:depends+=" R"
raku-dist.sh:depends+=" rakudo"
```

Re: [PR PATCH] [Updated] perl-module: add perl to build depends

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There is an updated pull request by zdykstra against master on the void-packages repository

https://github.com/zdykstra/void-packages perl-module
https://github.com/void-linux/void-packages/pull/23942

perl-module: add perl to build depends
There are 456 packages with a build style of `perl-module`. Of those 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.

A patch file from https://github.com/void-linux/void-packages/pull/23942.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-perl-module-23942.patch --]
[-- Type: text/x-diff, Size: 654 bytes --]

From 6b4ed02fdd23c061f0cf78eb20b6fa8109146e8d Mon Sep 17 00:00:00 2001
From: Zach Dykstra <dykstra.zachary@gmail.com>
Date: Wed, 29 Jul 2020 22:58:23 -0500
Subject: [PATCH] perl-module: add perl to build depends

---
 common/environment/build-style/perl-module.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/environment/build-style/perl-module.sh b/common/environment/build-style/perl-module.sh
index 2444d3d104f..300ed9b5db6 100644
--- a/common/environment/build-style/perl-module.sh
+++ b/common/environment/build-style/perl-module.sh
@@ -1 +1,4 @@
+hostmakedepends+=" perl"
+makedepends+=" perl"
+depends+=" perl"
 lib32disabled=yes

Re: perl-module: add perl to build depends

[zdykstra]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by zdykstra on void-packages repository

https://github.com/void-linux/void-packages/pull/23942#issuecomment-666101199

Comment:
> I like the idea. It could also add `perl` to `depends`.

That seems reasonable - there are three other build styles that do it as well. 

```
$ grep "^depends+" *
gem.sh:depends+=" ruby"
R-cran.sh:depends+=" R"
raku-dist.sh:depends+=" rakudo"
```

I've added it in to `perl-module.sh` as well.

Re: [PR PATCH] [Merged]: perl-module: add perl to build depends

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

There's a merged pull request on the void-packages repository

perl-module: add perl to build depends
https://github.com/void-linux/void-packages/pull/23942

Description:
There are 456 packages with a build style of `perl-module`. Of those, 455 have `perl` explicitly set for `$hostmakedepends` and 425 have `perl` set for `$makedepends`. 

I'm not sure it's reasonable to retroactively fix all of the templates using the `perl-module` build style, but future updates of templates can be cleaned up.