Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: batsignal-1.1.2
Date: Fri, 31 Jul 2020 02:34:49 +0200	[thread overview]
Message-ID: <20200731003449.FLiGm254PnT7biR9JgmHG-9WBfIdUVssSdF9dou0lb8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23963@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463344377

Comment:
It's in `libglib-devel`, but that's a `glib-devel` dependency anyway, so it should be available.

Note that most builds don't require runnning `make <command>` manually, you should leave it up to the build style. If, however, you need to run `make install` manually for some reason that isn't covered by setting `make_install_args`, you should run `make install` inside `do_install`, and `DESTDIR` should be set to `$DESTDIR`.

  parent reply	other threads:[~2020-07-31  0:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30 23:46 [PR PATCH] " motorto
2020-07-30 23:58 ` [PR PATCH] [Updated] " motorto
2020-07-31  0:13 ` motorto
2020-07-31  0:14 ` [PR REVIEW] " ericonr
2020-07-31  0:14 ` ericonr
2020-07-31  0:26 ` motorto
2020-07-31  0:28 ` motorto
2020-07-31  0:34 ` ericonr [this message]
2020-07-31  9:52 ` [PR PATCH] [Updated] " motorto
2020-07-31  9:57 ` [PR REVIEW] " motorto
2020-07-31 10:00 ` motorto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200731003449.FLiGm254PnT7biR9JgmHG-9WBfIdUVssSdF9dou0lb8@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).