Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
@ 2020-07-31  7:25 manneorama
  2020-07-31  7:41 ` [PR PATCH] [Updated] " manneorama
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: manneorama @ 2020-07-31  7:25 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

There is a new pull request by manneorama against master on the void-packages repository

https://github.com/manneorama/void-packages master
https://github.com/void-linux/void-packages/pull/23969

sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
This a quick and dirty solution to #23968 that just redirects stdout when checking the status of $NETWORK_MANAGER.

A patch file from https://github.com/void-linux/void-packages/pull/23969.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23969.patch --]
[-- Type: text/x-diff, Size: 1407 bytes --]

From 2a434757056583770a633e9c90d20d67b83be288 Mon Sep 17 00:00:00 2001
From: Emanuel Birge <emanuel.birge@tobii.com>
Date: Fri, 31 Jul 2020 09:04:21 +0200
Subject: [PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER
 status

---
 srcpkgs/sv-netmount/files/netmount/run | 2 +-
 srcpkgs/sv-netmount/template           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sv-netmount/files/netmount/run b/srcpkgs/sv-netmount/files/netmount/run
index 6214befa9c8..f00da44b28e 100755
--- a/srcpkgs/sv-netmount/files/netmount/run
+++ b/srcpkgs/sv-netmount/files/netmount/run
@@ -3,7 +3,7 @@
 [ -r conf ] && . ./conf
 
 # Ensure the network manager is running
-[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2> /dev/null || exit 1
+[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2>&1 /dev/null || exit 1
 
 # If it's running or not in used - rc.local - discover default gateway
 if [ -z "$GATEWAY" ]; then
diff --git a/srcpkgs/sv-netmount/template b/srcpkgs/sv-netmount/template
index 3ee020cf237..141cb95fe49 100644
--- a/srcpkgs/sv-netmount/template
+++ b/srcpkgs/sv-netmount/template
@@ -1,7 +1,7 @@
 # Template file for 'sv-netmount'
 pkgname=sv-netmount
 version=0.1
-revision=2
+revision=3
 short_desc="Service to mount/umount network filesystems from fstab"
 homepage="http://www.voidlinux.org/"
 maintainer="Olivier Mauras <olivier@mauras.ch>"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
  2020-07-31  7:25 [PR PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status manneorama
@ 2020-07-31  7:41 ` manneorama
  2020-07-31  7:49 ` manneorama
  2020-07-31  8:01 ` manneorama
  2 siblings, 0 replies; 4+ messages in thread
From: manneorama @ 2020-07-31  7:41 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

There is an updated pull request by manneorama against master on the void-packages repository

https://github.com/manneorama/void-packages master
https://github.com/void-linux/void-packages/pull/23969

sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
This a quick and dirty solution to #23968 that just redirects stdout when checking the status of $NETWORK_MANAGER.

A patch file from https://github.com/void-linux/void-packages/pull/23969.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23969.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]

From d8bd80406fda7a6256382ccfde534a3a1bde7e3c Mon Sep 17 00:00:00 2001
From: Emanuel Birge <emanuel.birge@tobii.com>
Date: Fri, 31 Jul 2020 09:04:21 +0200
Subject: [PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER
 status

---
 srcpkgs/sv-netmount/files/netmount/run | 2 +-
 srcpkgs/sv-netmount/template           | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/sv-netmount/files/netmount/run b/srcpkgs/sv-netmount/files/netmount/run
index 6214befa9c8..f00da44b28e 100755
--- a/srcpkgs/sv-netmount/files/netmount/run
+++ b/srcpkgs/sv-netmount/files/netmount/run
@@ -3,7 +3,7 @@
 [ -r conf ] && . ./conf
 
 # Ensure the network manager is running
-[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2> /dev/null || exit 1
+[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2>&1 /dev/null || exit 1
 
 # If it's running or not in used - rc.local - discover default gateway
 if [ -z "$GATEWAY" ]; then
diff --git a/srcpkgs/sv-netmount/template b/srcpkgs/sv-netmount/template
index 3ee020cf237..eb39ced2c23 100644
--- a/srcpkgs/sv-netmount/template
+++ b/srcpkgs/sv-netmount/template
@@ -1,12 +1,12 @@
 # Template file for 'sv-netmount'
 pkgname=sv-netmount
 version=0.1
-revision=2
+revision=3
+build_style="meta"
 short_desc="Service to mount/umount network filesystems from fstab"
 homepage="http://www.voidlinux.org/"
 maintainer="Olivier Mauras <olivier@mauras.ch>"
 license="GPL-2"
-build_style="meta"
 
 depends="runit"
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Updated] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
  2020-07-31  7:25 [PR PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status manneorama
  2020-07-31  7:41 ` [PR PATCH] [Updated] " manneorama
@ 2020-07-31  7:49 ` manneorama
  2020-07-31  8:01 ` manneorama
  2 siblings, 0 replies; 4+ messages in thread
From: manneorama @ 2020-07-31  7:49 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

There is an updated pull request by manneorama against master on the void-packages repository

https://github.com/manneorama/void-packages master
https://github.com/void-linux/void-packages/pull/23969

sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
This a quick and dirty solution to #23968 that just redirects stdout when checking the status of $NETWORK_MANAGER.

A patch file from https://github.com/void-linux/void-packages/pull/23969.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-23969.patch --]
[-- Type: text/x-diff, Size: 1559 bytes --]

From de95bf61e37ae367096ba18a74cab20417ccad38 Mon Sep 17 00:00:00 2001
From: Emanuel Birge <emanuel.birge@tobii.com>
Date: Fri, 31 Jul 2020 09:04:21 +0200
Subject: [PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER
 status

---
 srcpkgs/sv-netmount/files/netmount/run | 2 +-
 srcpkgs/sv-netmount/template           | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sv-netmount/files/netmount/run b/srcpkgs/sv-netmount/files/netmount/run
index 6214befa9c8..f00da44b28e 100755
--- a/srcpkgs/sv-netmount/files/netmount/run
+++ b/srcpkgs/sv-netmount/files/netmount/run
@@ -3,7 +3,7 @@
 [ -r conf ] && . ./conf
 
 # Ensure the network manager is running
-[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2> /dev/null || exit 1
+[ -z "$NETWORK_MANAGER" ] || sv check "$NETWORK_MANAGER" 2>&1 /dev/null || exit 1
 
 # If it's running or not in used - rc.local - discover default gateway
 if [ -z "$GATEWAY" ]; then
diff --git a/srcpkgs/sv-netmount/template b/srcpkgs/sv-netmount/template
index 3ee020cf237..126157fe70d 100644
--- a/srcpkgs/sv-netmount/template
+++ b/srcpkgs/sv-netmount/template
@@ -1,12 +1,12 @@
 # Template file for 'sv-netmount'
 pkgname=sv-netmount
 version=0.1
-revision=2
+revision=3
+build_style="meta"
 short_desc="Service to mount/umount network filesystems from fstab"
-homepage="http://www.voidlinux.org/"
 maintainer="Olivier Mauras <olivier@mauras.ch>"
-license="GPL-2"
-build_style="meta"
+license="GPL-2.0-or-later"
+homepage="http://www.voidlinux.org/"
 
 depends="runit"
 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: sv-netmount: redirect stdout when checking $NETWORK_MANAGER status
  2020-07-31  7:25 [PR PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status manneorama
  2020-07-31  7:41 ` [PR PATCH] [Updated] " manneorama
  2020-07-31  7:49 ` manneorama
@ 2020-07-31  8:01 ` manneorama
  2 siblings, 0 replies; 4+ messages in thread
From: manneorama @ 2020-07-31  8:01 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by manneorama on void-packages repository

https://github.com/void-linux/void-packages/pull/23969#issuecomment-666991414

Comment:
Also made the linter happy

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  7:25 [PR PATCH] sv-netmount: redirect stdout when checking $NETWORK_MANAGER status manneorama
2020-07-31  7:41 ` [PR PATCH] [Updated] " manneorama
2020-07-31  7:49 ` manneorama
2020-07-31  8:01 ` manneorama

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git