Github messages for voidlinux
 help / color / Atom feed
* [PR PATCH] New package: batsignal-1.1.2
@ 2020-07-30 23:46 motorto
  2020-07-30 23:58 ` [PR PATCH] [Updated] " motorto
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: motorto @ 2020-07-30 23:46 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

There is a new pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal
https://github.com/void-linux/void-packages/pull/23963

New package: batsignal-1.1.2
Batsignal is a lightweight battery daemon written in C that notifies the user about various battery states.

A patch file from https://github.com/void-linux/void-packages/pull/23963.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-23963.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

From 05c501f8432d487a86393d7c3fcfd458994c80b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 00:42:21 +0100
Subject: [PATCH] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/batsignal/template

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
new file mode 100644
index 00000000000..ba58ee0fcb1
--- /dev/null
+++ b/srcpkgs/batsignal/template
@@ -0,0 +1,18 @@
+# Template file for 'batsignal'
+pkgname=batsignal
+version=1.1.2
+revision=1
+archs=noarch
+build_style=gnu-makefile
+makedepends=" libnotify-devel make pkg-config glib-devel "
+short_desc="Simple battery monitor"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="ISC"
+homepage="https://github.com/electrickite/batsignal"
+distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
+checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
+
+do_build() {
+  make PREFIX=/usr DESTDIR="${pkgdir}" install
+  vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
@ 2020-07-30 23:58 ` motorto
  2020-07-31  0:13 ` motorto
                   ` (8 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-30 23:58 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal
https://github.com/void-linux/void-packages/pull/23963

New package: batsignal-1.1.2
Batsignal is a lightweight battery daemon written in C that notifies the user about various battery states.

A patch file from https://github.com/void-linux/void-packages/pull/23963.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-23963.patch --]
[-- Type: text/x-diff, Size: 1954 bytes --]

From 05c501f8432d487a86393d7c3fcfd458994c80b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 00:42:21 +0100
Subject: [PATCH 1/2] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/batsignal/template

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
new file mode 100644
index 00000000000..ba58ee0fcb1
--- /dev/null
+++ b/srcpkgs/batsignal/template
@@ -0,0 +1,18 @@
+# Template file for 'batsignal'
+pkgname=batsignal
+version=1.1.2
+revision=1
+archs=noarch
+build_style=gnu-makefile
+makedepends=" libnotify-devel make pkg-config glib-devel "
+short_desc="Simple battery monitor"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="ISC"
+homepage="https://github.com/electrickite/batsignal"
+distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
+checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
+
+do_build() {
+  make PREFIX=/usr DESTDIR="${pkgdir}" install
+  vlicense LICENSE
+}

From 1d01bae9b2a34f900618e2269ec9f5ca0a3f6f61 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 00:57:55 +0100
Subject: [PATCH 2/2] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index ba58ee0fcb1..2989708e37c 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -13,6 +13,6 @@ distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
 checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
 
 do_build() {
-  make PREFIX=/usr DESTDIR="${pkgdir}" install
-  vlicense LICENSE
+	xmake PREFIX=/usr DESTDIR="${pkgdir}" install
+	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
  2020-07-30 23:58 ` [PR PATCH] [Updated] " motorto
@ 2020-07-31  0:13 ` motorto
  2020-07-31  0:14 ` [PR REVIEW] " ericonr
                   ` (7 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31  0:13 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#issuecomment-666809352

Comment:
Well it fails some test because of:
>  #include <libnotify/notify.h>

Shouldn't libnotify-devel fix this issues ?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
  2020-07-30 23:58 ` [PR PATCH] [Updated] " motorto
  2020-07-31  0:13 ` motorto
@ 2020-07-31  0:14 ` ericonr
  2020-07-31  0:14 ` ericonr
                   ` (6 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-07-31  0:14 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463338360

Comment:
No need for a space after or before the quotes

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (2 preceding siblings ...)
  2020-07-31  0:14 ` [PR REVIEW] " ericonr
@ 2020-07-31  0:14 ` ericonr
  2020-07-31  0:26 ` motorto
                   ` (5 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-07-31  0:14 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463339001

Comment:
`xmake` doesn't exist in void.

Since you're using the `gnu-makefile` build style, first try it without setting any function, its defaults are usually good enough for most programs. If it works, you will only need to run `vlicense LICENSE` in `post_install()`.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (3 preceding siblings ...)
  2020-07-31  0:14 ` ericonr
@ 2020-07-31  0:26 ` motorto
  2020-07-31  0:28 ` motorto
                   ` (4 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31  0:26 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463342254

Comment:
Sorry first time using git to pull request , didn't know that function existed ! 
I am going to take care of that and will squash the commits this time :)

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (4 preceding siblings ...)
  2020-07-31  0:26 ` motorto
@ 2020-07-31  0:28 ` motorto
  2020-07-31  0:34 ` ericonr
                   ` (3 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31  0:28 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463342796

Comment:
Actually that's a typo. And now magically appears fails the compilation because of glib.h ... 
Isn't that on the glib-devel ? 

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (5 preceding siblings ...)
  2020-07-31  0:28 ` motorto
@ 2020-07-31  0:34 ` ericonr
  2020-07-31  9:52 ` [PR PATCH] [Updated] " motorto
                   ` (2 subsequent siblings)
  9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-07-31  0:34 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463344377

Comment:
It's in `libglib-devel`, but that's a `glib-devel` dependency anyway, so it should be available.

Note that most builds don't require runnning `make <command>` manually, you should leave it up to the build style. If, however, you need to run `make install` manually for some reason that isn't covered by setting `make_install_args`, you should run `make install` inside `do_install`, and `DESTDIR` should be set to `$DESTDIR`.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR PATCH] [Updated] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (6 preceding siblings ...)
  2020-07-31  0:34 ` ericonr
@ 2020-07-31  9:52 ` motorto
  2020-07-31  9:57 ` [PR REVIEW] " motorto
  2020-07-31 10:00 ` motorto
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31  9:52 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

There is an updated pull request by motorto against master on the void-packages repository

https://github.com/motorto/void-packages batsignal
https://github.com/void-linux/void-packages/pull/23963

New package: batsignal-1.1.2
Batsignal is a lightweight battery daemon written in C that notifies the user about various battery states.

A patch file from https://github.com/void-linux/void-packages/pull/23963.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-batsignal-23963.patch --]
[-- Type: text/x-diff, Size: 3090 bytes --]

From 05c501f8432d487a86393d7c3fcfd458994c80b8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 00:42:21 +0100
Subject: [PATCH 1/3] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/batsignal/template

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
new file mode 100644
index 00000000000..ba58ee0fcb1
--- /dev/null
+++ b/srcpkgs/batsignal/template
@@ -0,0 +1,18 @@
+# Template file for 'batsignal'
+pkgname=batsignal
+version=1.1.2
+revision=1
+archs=noarch
+build_style=gnu-makefile
+makedepends=" libnotify-devel make pkg-config glib-devel "
+short_desc="Simple battery monitor"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="ISC"
+homepage="https://github.com/electrickite/batsignal"
+distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
+checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
+
+do_build() {
+  make PREFIX=/usr DESTDIR="${pkgdir}" install
+  vlicense LICENSE
+}

From 1d01bae9b2a34f900618e2269ec9f5ca0a3f6f61 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 00:57:55 +0100
Subject: [PATCH 2/3] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index ba58ee0fcb1..2989708e37c 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -13,6 +13,6 @@ distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
 checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
 
 do_build() {
-  make PREFIX=/usr DESTDIR="${pkgdir}" install
-  vlicense LICENSE
+	xmake PREFIX=/usr DESTDIR="${pkgdir}" install
+	vlicense LICENSE
 }

From d07b293ce43f0523e3a11fc28f8d073ffc818e4e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Fri, 31 Jul 2020 10:50:30 +0100
Subject: [PATCH 3/3] New package: batsignal-1.1.2

---
 srcpkgs/batsignal/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/batsignal/template b/srcpkgs/batsignal/template
index 2989708e37c..fed8dacc750 100644
--- a/srcpkgs/batsignal/template
+++ b/srcpkgs/batsignal/template
@@ -4,7 +4,7 @@ version=1.1.2
 revision=1
 archs=noarch
 build_style=gnu-makefile
-makedepends=" libnotify-devel make pkg-config glib-devel "
+makedepends="libnotify-devel make pkg-config libglib-devel"
 short_desc="Simple battery monitor"
 maintainer="André Cerqueira <acerqueira021@gmail.com>"
 license="ISC"
@@ -12,7 +12,6 @@ homepage="https://github.com/electrickite/batsignal"
 distfiles="https://github.com/electrickite/batsignal/archive/${version}.tar.gz"
 checksum=00cb30df33b5fee049963657f341e963a0f094dbf1620397bf1e56fa07191e7c
 
-do_build() {
-	xmake PREFIX=/usr DESTDIR="${pkgdir}" install
+post_install() {
 	vlicense LICENSE
 }

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (7 preceding siblings ...)
  2020-07-31  9:52 ` [PR PATCH] [Updated] " motorto
@ 2020-07-31  9:57 ` motorto
  2020-07-31 10:00 ` motorto
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31  9:57 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463519673

Comment:
Fixed that thing ! But now I keep getting that glib.h , I am putting the dependencies on the wrong side ?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PR REVIEW] New package: batsignal-1.1.2
  2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
                   ` (8 preceding siblings ...)
  2020-07-31  9:57 ` [PR REVIEW] " motorto
@ 2020-07-31 10:00 ` motorto
  9 siblings, 0 replies; 11+ messages in thread
From: motorto @ 2020-07-31 10:00 UTC (permalink / raw)
  To: ml


[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New review comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/23963#discussion_r463519673

Comment:
Fixed that thing ! But now I keep getting that glib.h , I am putting the dependencies on the wrong side ?
should I change this pull to draft ? 



^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, back to index

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 23:46 [PR PATCH] New package: batsignal-1.1.2 motorto
2020-07-30 23:58 ` [PR PATCH] [Updated] " motorto
2020-07-31  0:13 ` motorto
2020-07-31  0:14 ` [PR REVIEW] " ericonr
2020-07-31  0:14 ` ericonr
2020-07-31  0:26 ` motorto
2020-07-31  0:28 ` motorto
2020-07-31  0:34 ` ericonr
2020-07-31  9:52 ` [PR PATCH] [Updated] " motorto
2020-07-31  9:57 ` [PR REVIEW] " motorto
2020-07-31 10:00 ` motorto

Github messages for voidlinux

Archives are clonable: git clone --mirror http://inbox.vuxu.org/voidlinux-github

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.voidlinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git