[PR PATCH] xbps-src: enable C.UTF-8 locale on glibc masterdir

[PR PATCH] xbps-src: enable C.UTF-8 locale on glibc masterdir

[sgn]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages masterdir-locale
https://github.com/void-linux/void-packages/pull/23897

xbps-src: enable C.UTF-8 locale on glibc masterdir
`util-linux` requires `C.UTF-8` for testing.

Since this is an important part of system,
enable `C.UTF-8' for checking `util-linux`.

A patch file from https://github.com/void-linux/void-packages/pull/23897.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-masterdir-locale-23897.patch --]
[-- Type: text/x-diff, Size: 1139 bytes --]

From acca830c125f80e26f42a90dd385fc4b610f4fe6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Tue, 28 Jul 2020 21:09:54 +0700
Subject: [PATCH] xbps-src: enable C.UTF-8 locale on glibc masterdir

`util-linux` requires `C.UTF-8` for testing.

Since this is an important part of system,
enable `C.UTF-8' for checking `util-linux`.
---
 common/xbps-src/shutils/chroot.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/chroot.sh b/common/xbps-src/shutils/chroot.sh
index 436f8866cd4..ea63bf7e779 100644
--- a/common/xbps-src/shutils/chroot.sh
+++ b/common/xbps-src/shutils/chroot.sh
@@ -132,7 +132,10 @@ chroot_prepare() {
 
     # Prepare default locale: en_US.UTF-8.
     if [ -s ${XBPS_MASTERDIR}/etc/default/libc-locales ]; then
-        echo 'en_US.UTF-8 UTF-8' >> ${XBPS_MASTERDIR}/etc/default/libc-locales
+        printf '%s\n' \
+            'C.UTF-8 UTF-8' \
+            'en_US.UTF-8 UTF-8' \
+            >> ${XBPS_MASTERDIR}/etc/default/libc-locales
     fi
 
     touch -f $XBPS_MASTERDIR/.xbps_chroot_init

Re: [PR REVIEW] xbps-src: enable C.UTF-8 locale on glibc masterdir

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/23897#discussion_r461655668

Comment:
This should be two times `'%s\n%s\n'`, no?

Re: [PR REVIEW] xbps-src: enable C.UTF-8 locale on glibc masterdir

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/23897#discussion_r461655668

Comment:
This should be two strings, i.e. `'%s\n%s\n'`, no?

Re: [PR REVIEW] xbps-src: enable C.UTF-8 locale on glibc masterdir

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23897#discussion_r461807388

Comment:
Bash specifies that

> The format is reused as necessary to consume all of the
arguments.  If the format requires more arguments than are
supplied, the extra format specifications behave as if a zero
value or null string, as appropriate, had been supplied.

Re: [PR REVIEW] xbps-src: enable C.UTF-8 locale on glibc masterdir

[sgn]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23897#discussion_r461998777

Comment:
The argument still holds true for any POSIX conformant `printf(1)`.
Point 9. of EXTENDED DESCRIPTION https://pubs.opengroup.org/onlinepubs/9699919799/utilities/printf.html#tag_20_94_13

> The format operand shall be reused as often as necessary to satisfy the argument operands. Any extra b, c, or s conversion specifiers shall be evaluated as if a null string argument were supplied; other extra conversion specifications shall be evaluated as if a zero argument were supplied. If the format operand contains no conversion specifications and argument operands are present, the results are unspecified.

Re: xbps-src: enable C.UTF-8 locale on glibc masterdir

[sgn]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23897#issuecomment-668299491

Comment:
I guess silence meant no-objection? Will merge tomorrow?

Re: [PR PATCH] [Merged]: xbps-src: enable C.UTF-8 locale on glibc masterdir

[sgn]

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: enable C.UTF-8 locale on glibc masterdir
https://github.com/void-linux/void-packages/pull/23897

Description:
`util-linux` requires `C.UTF-8` for testing.

Since this is an important part of system,
enable `C.UTF-8' for checking `util-linux`.