From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: xmoto: update to 0.6.1.
Date: Tue, 04 Aug 2020 02:50:07 +0200 [thread overview]
Message-ID: <20200804005007.xydp-V_VbcfTlfxF2IWzusPoGBB6_wbvSI4O03htZ7c@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24030@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24030#issuecomment-668311607
Comment:
I've spent sometime to read their `CMakeLists.txt`
They have `find_package(Intl, REQUIRED)` already, so the template can be a bit simpler:
```diff
diff --git a/srcpkgs/xmoto/template b/srcpkgs/xmoto/template
index d91f92f782..ae400bdce0 100644
--- a/srcpkgs/xmoto/template
+++ b/srcpkgs/xmoto/template
@@ -9,7 +9,7 @@ hostmakedepends="automake libtool gettext-devel intltool desktop-file-utils"
makedepends="sqlite-devel zlib-devel libjpeg-turbo-devel libpng-devel
libxml2-devel libxdg-basedir-devel glu-devel SDL-devel SDL_mixer-devel
SDL_net-devel SDL_ttf-devel lua52-devel libcurl-devel libode-devel bzip2-devel
- gettext-devel"
+ gettext-libs"
depends="${pkgname}-data"
short_desc="2D motocross platform game"
maintainer="Enno Boland <gottox@voidlinux.org>"
@@ -18,10 +18,6 @@ homepage="http://xmoto.tuxfamily.org/"
distfiles="https://github.com/xmoto/xmoto/archive/${version}/${version}.tar.gz"
checksum=209c8c38b1742d0620d40f90365c7a56f67c86da826c80a76d37fa46ee9c9b66
-if [ $XBPS_TARGET_LIBC = "musl" ]; then
- export LDFLAGS+=" -lintl"
-fi
-
pre_install() {
vtargetrun build/src/xmoto --pack build/bin/xmoto.bin bin/
}
```
next prev parent reply other threads:[~2020-08-04 0:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 21:28 [PR PATCH] " abenson
2020-08-03 21:32 ` [PR REVIEW] " ericonr
2020-08-03 23:05 ` [PR PATCH] [Updated] " abenson
2020-08-04 0:03 ` abenson
2020-08-04 0:04 ` abenson
2020-08-04 0:29 ` sgn
2020-08-04 0:30 ` sgn
2020-08-04 0:31 ` sgn
2020-08-04 0:42 ` [PR PATCH] [Updated] " abenson
2020-08-04 0:50 ` sgn [this message]
2020-08-04 0:51 ` ericonr
2020-08-04 0:57 ` [PR PATCH] [Updated] " abenson
2020-08-04 0:57 ` sgn
2020-08-04 1:26 ` [PR PATCH] [Merged]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804005007.xydp-V_VbcfTlfxF2IWzusPoGBB6_wbvSI4O03htZ7c@z \
--to=sgn@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).