Re: [PR PATCH] [Updated] chromium: update to 84.0.4147.105.

[pbui <pbui@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages chromium
https://github.com/void-linux/void-packages/pull/23903

chromium: update to 84.0.4147.105. 
- Built for x86_64 and x86_64-musl.
- Tested on x86_64.

- Drop unnecessary secure_getenv musl patch.

- Turn on js_optimize by default.

- Also update chromium-widevine and modify INSTALL to use `mktemp -d` instead of hardcoded path.

A patch file from https://github.com/void-linux/void-packages/pull/23903.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chromium-23903.patch --]
[-- Type: text/x-diff, Size: 5114 bytes --]

From 6740c3113538eb2bcb8d0a8d49ee032dcfda99ce Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Tue, 28 Jul 2020 11:42:24 -0400
Subject: [PATCH 1/2] chromium: update to 84.0.4147.105.

[ci skip]

- Built for x86_64 and x86_64-musl.
- Tested on x86_64.

- Drop unnecessary secure_getenv musl patch.

- Turn on js_optimize by default.

- Use system libvpx
---
 .../musl-patches/dont-assume-secure-getenv.patch  | 13 -------------
 srcpkgs/chromium/template                         | 15 ++++++---------
 2 files changed, 6 insertions(+), 22 deletions(-)
 delete mode 100644 srcpkgs/chromium/files/musl-patches/dont-assume-secure-getenv.patch

diff --git a/srcpkgs/chromium/files/musl-patches/dont-assume-secure-getenv.patch b/srcpkgs/chromium/files/musl-patches/dont-assume-secure-getenv.patch
deleted file mode 100644
index abde598d8fd..00000000000
--- a/srcpkgs/chromium/files/musl-patches/dont-assume-secure-getenv.patch
+++ /dev/null
@@ -1,13 +0,0 @@
---- third_party/angle/third_party/vulkan-loader/src/BUILD.gn.orig	2020-02-08 16:16:30.786747326 -0500
-+++ third_party/angle/third_party/vulkan-loader/src/BUILD.gn	2020-02-08 16:17:02.682797286 -0500
-@@ -59,10 +59,6 @@
-   if (is_win) {
-     cflags = [ "/wd4201" ]
-   }
--  if (is_linux) {
--    # assume secure_getenv() is available
--    defines += [ "HAVE_SECURE_GETENV" ]
--  }
- }
- 
- if (!is_android) {
diff --git a/srcpkgs/chromium/template b/srcpkgs/chromium/template
index aae904de440..061e09efe52 100644
--- a/srcpkgs/chromium/template
+++ b/srcpkgs/chromium/template
@@ -1,7 +1,7 @@
 # Template file for 'chromium'
 pkgname=chromium
 # See http://www.chromium.org/developers/calendar for the latest version
-version=84.0.4147.89
+version=84.0.4147.105
 revision=1
 archs="i686* x86_64* aarch64* armv7l*"
 short_desc="Google's attempt at creating a safer, faster, and more stable browser"
@@ -9,7 +9,7 @@ maintainer="Enno Boland <gottox@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://www.chromium.org/"
 distfiles="https://commondatastorage.googleapis.com/chromium-browser-official/${pkgname}-${version}.tar.xz"
-checksum=17970d998c125b40765141f2cd346d1674f05dbd4a28fdcf31f9e3540890c679
+checksum=caf4ebeb2a2333454c3067a2534aeecaab5029aa78fc0d8b27f79ad3b9c5ccac
 nocross=yes
 
 lib32disabled=yes
@@ -34,14 +34,11 @@ makedepends="libpng-devel gtk+-devel gtk+3-devel nss-devel pciutils-devel
  libjpeg-turbo-devel libevent-devel json-c-devel harfbuzz-devel
  minizip-devel jsoncpp-devel zlib-devel libcap-devel libXdamage-devel
  re2-devel fontconfig-devel freetype-devel opus-devel
- ffmpeg-devel libva-devel python-setuptools xcb-proto $(vopt_if sndio sndio-devel)"
+ ffmpeg-devel libvpx-devel libva-devel python-setuptools xcb-proto
+ $(vopt_if sndio sndio-devel)"
 depends="libexif hwids desktop-file-utils hicolor-icon-theme xdg-utils"
 
-build_options_default="clang pulseaudio vaapi"
-
-case "${XBPS_TARGET_MACHINE}" in
-	x86_64|i686) build_options_default+=" js_optimize" ;;
-esac
+build_options_default="clang js_optimize vaapi pulseaudio"
 
 post_extract() {
 	case "${XBPS_TARGET_MACHINE}" in
@@ -98,7 +95,6 @@ do_configure() {
 	# use_system_protobuf
 	# use_system_v8=1
 	# use_system_zlib=1
-	# use_system_libvpx=1
 	# bzip2 jsoncpp minizip xdg_utils speex
 	system="
 		ffmpeg
@@ -109,6 +105,7 @@ do_configure() {
 		libevent
 		libjpeg
 		libpng
+		libvpx
 		libwebp
 		libxml
 		libxslt

From e8f09944feb609668dc3beb6ee95653c1ed5e006 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Tue, 28 Jul 2020 14:20:30 -0400
Subject: [PATCH 2/2] chromium-widevine: update to 84.0.4147.105.

[ci skip]

- Modify INSTALL to use `mktemp -d` instead of hardcoded path.
---
 srcpkgs/chromium-widevine/INSTALL  | 2 +-
 srcpkgs/chromium-widevine/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/chromium-widevine/INSTALL b/srcpkgs/chromium-widevine/INSTALL
index 4d9267196e3..2bf5321f9ae 100644
--- a/srcpkgs/chromium-widevine/INSTALL
+++ b/srcpkgs/chromium-widevine/INSTALL
@@ -1,6 +1,6 @@
 # INSTALL
 DISTFILE="https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb"
-BUILD_DIR="$PWD/var/tmp/$PKGNAME.build"
+BUILD_DIR="$(mktemp -d ${TMPDIR:-/tmp}/$PKGNAME.XXXXXX)"
 case "$ACTION" in
 post)
     # Actions to execute before the package files are unpacked.
diff --git a/srcpkgs/chromium-widevine/template b/srcpkgs/chromium-widevine/template
index 70f097c7c08..ada3f947519 100644
--- a/srcpkgs/chromium-widevine/template
+++ b/srcpkgs/chromium-widevine/template
@@ -6,7 +6,7 @@ _chromeVersion="current"
 _channel="stable"
 
 pkgname=chromium-widevine
-version=84.0.4147.89
+version=84.0.4147.105
 revision=1
 archs="x86_64"
 create_wrksrc=yes
@@ -17,7 +17,7 @@ depends="chromium binutils xz"
 homepage="https://www.google.com/chrome"
 repository=nonfree
 distfiles="https://dl.google.com/linux/direct/google-chrome-${_channel}_${_chromeVersion}_amd64.deb"
-checksum=9f8fd8f23a8402c45ef90668285dd37407ae13801fda652fb31a4f2ff47ef0c3
+checksum=dc7fa2ca2dccf482524dc2a343662859a22ad1fb33767447d7de6fcf6cc1dd7e
 
 do_extract() {
 	: