Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Use libintl on musl when necessary
Date: Thu, 06 Aug 2020 15:43:14 +0200	[thread overview]
Message-ID: <20200806134314.do4G6IRnARA1P1TUREY2IDmxND45_ZPcttwrsLnre-g@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24037@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24037#discussion_r466421668

Comment:
CMake doesn't ignore it.
`cmake` just makes it hard to use correctly.
They pass `$LDFLAGS` before `*.a`, by order of filename, it couldn't file symbols in those libs.

`cmake` is `cmake`.

  parent reply	other threads:[~2020-08-06 13:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  1:16 [PR PATCH] " ericonr
2020-08-04  1:18 ` [PR PATCH] [Updated] " ericonr
2020-08-04  1:31 ` [PR REVIEW] " sgn
2020-08-04  1:31 ` sgn
2020-08-04  1:33 ` ericonr
2020-08-05 16:29 ` ericonr
2020-08-06 13:43 ` sgn [this message]
2020-08-07  0:41 ` sgn
2020-08-07 11:31 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200806134314.do4G6IRnARA1P1TUREY2IDmxND45_ZPcttwrsLnre-g@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).