Github messages for voidlinux
 help / color / mirror / Atom feed
From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: wabt-1.0.19
Date: Thu, 06 Aug 2020 22:23:46 +0200	[thread overview]
Message-ID: <20200806202346.30e23sYctkpNz8cAeH64Mz7ucTJOUWAOO45ht1HpTFY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23932@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#issuecomment-670173670

Comment:
Please add `make_check_target=check`, `checkdepends="python3-ply"` and gtest, testsuite submodules so tests can be run. Use d2163dace09d647bccf34b9b82a6f05a3b23cf29 version of testsuite, matching release.

On moving submodules, use commit hashes rather than globbing:
```
rmdir third_party/wasm-c-api
mv ../wasm-c-api-${_wasm_c_api_commit} third_party/wasm-c-api
```

  parent reply	other threads:[~2020-08-06 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 18:45 [PR PATCH] " ifreund
2020-07-29 18:52 ` [PR REVIEW] " Chocimier
2020-07-29 18:57 ` ifreund
2020-07-29 19:21 ` [PR PATCH] [Updated] " ifreund
2020-07-29 19:39 ` [PR REVIEW] " ifreund
2020-08-06 20:23 ` Chocimier [this message]
2020-08-06 23:55 ` [PR PATCH] [Updated] " ifreund
2020-08-06 23:56 ` ifreund
2020-08-06 23:57 ` ifreund
2020-08-07 19:16 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200806202346.30e23sYctkpNz8cAeH64Mz7ucTJOUWAOO45ht1HpTFY@z \
    --to=chocimier@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).