Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: wabt-1.0.19
@ 2020-07-29 18:45 ifreund
  2020-07-29 18:52 ` [PR REVIEW] " Chocimier
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: ifreund @ 2020-07-29 18:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

There is a new pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages wabt
https://github.com/void-linux/void-packages/pull/23932

New package: wabt-1.0.19


A patch file from https://github.com/void-linux/void-packages/pull/23932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wabt-23932.patch --]
[-- Type: text/x-diff, Size: 1240 bytes --]

From ff64ca48c0816311dd81c33b00922ddc98090c6a Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Wed, 29 Jul 2020 20:44:39 +0200
Subject: [PATCH] New package: wabt-1.0.19

---
 srcpkgs/wabt/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/wabt/template

diff --git a/srcpkgs/wabt/template b/srcpkgs/wabt/template
new file mode 100644
index 00000000000..05ae7b604d9
--- /dev/null
+++ b/srcpkgs/wabt/template
@@ -0,0 +1,19 @@
+# Template file for 'wabt'
+pkgname=wabt
+version=1.0.19
+revision=1
+build_style=cmake
+short_desc="WebAssembly Binary Toolkit "
+maintainer="Isaac Freund <ifreund@ifreund.xyz>"
+license="Apache-2.0"
+homepage="https://github.com/WebAssembly/wabt"
+_wasm_c_api_commit=d9a80099d496b5cdba6f3fe8fc77586e0e505ddc
+distfiles="https://github.com/WebAssembly/wabt/archive/${version}.tar.gz
+ https://github.com/WebAssembly/wasm-c-api/archive/${_wasm_c_api_commit}.tar.gz"
+checksum="134f2afc8205d0a3ab89c5f0d424ff3823e9d2769c39d2235aa37eba7abc15ba
+ aea8cd095e9937f1e14f2c93e026317b197eb2345e7a817fe3932062eb7b792c"
+
+pre_configure() {
+	# copy submodule to proper location
+	cp -rup ${XBPS_BUILDDIR}/wasm-c-api-*/* ${wrksrc}/third_party/wasm-c-api
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
@ 2020-07-29 18:52 ` Chocimier
  2020-07-29 18:57 ` ifreund
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2020-07-29 18:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 243 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#discussion_r462515449

Comment:
Please rather move like in `tracebox`, otherwise ${XBPS_BUILDDIR}/wasm-c-api won't be cleaned.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
  2020-07-29 18:52 ` [PR REVIEW] " Chocimier
@ 2020-07-29 18:57 ` ifreund
  2020-07-29 19:21 ` [PR PATCH] [Updated] " ifreund
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-07-29 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#discussion_r462518126

Comment:
Will fix for this and `wasmtime`, I just copied blindly from `ppsspp` which I will also fix in a minute then.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
  2020-07-29 18:52 ` [PR REVIEW] " Chocimier
  2020-07-29 18:57 ` ifreund
@ 2020-07-29 19:21 ` ifreund
  2020-07-29 19:39 ` [PR REVIEW] " ifreund
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-07-29 19:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

There is an updated pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages wabt
https://github.com/void-linux/void-packages/pull/23932

New package: wabt-1.0.19


A patch file from https://github.com/void-linux/void-packages/pull/23932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wabt-23932.patch --]
[-- Type: text/x-diff, Size: 1279 bytes --]

From c914d878db266a6b54b228f6d85e401062041377 Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Wed, 29 Jul 2020 20:44:39 +0200
Subject: [PATCH] New package: wabt-1.0.19

---
 srcpkgs/wabt/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/wabt/template

diff --git a/srcpkgs/wabt/template b/srcpkgs/wabt/template
new file mode 100644
index 00000000000..009491904a4
--- /dev/null
+++ b/srcpkgs/wabt/template
@@ -0,0 +1,20 @@
+# Template file for 'wabt'
+pkgname=wabt
+version=1.0.19
+revision=1
+build_style=cmake
+short_desc="WebAssembly Binary Toolkit "
+maintainer="Isaac Freund <ifreund@ifreund.xyz>"
+license="Apache-2.0"
+homepage="https://github.com/WebAssembly/wabt"
+_wasm_c_api_commit=d9a80099d496b5cdba6f3fe8fc77586e0e505ddc
+distfiles="https://github.com/WebAssembly/wabt/archive/${version}.tar.gz
+ https://github.com/WebAssembly/wasm-c-api/archive/${_wasm_c_api_commit}.tar.gz"
+checksum="134f2afc8205d0a3ab89c5f0d424ff3823e9d2769c39d2235aa37eba7abc15ba
+ aea8cd095e9937f1e14f2c93e026317b197eb2345e7a817fe3932062eb7b792c"
+
+pre_configure() {
+	# move submodule to proper location
+	mv -v ${XBPS_BUILDDIR}/wasm-c-api-*/* ${wrksrc}/third_party/wasm-c-api
+	rm -rv ${XBPS_BUILDDIR}/wasm-c-api-*/
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (2 preceding siblings ...)
  2020-07-29 19:21 ` [PR PATCH] [Updated] " ifreund
@ 2020-07-29 19:39 ` ifreund
  2020-08-06 20:23 ` Chocimier
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-07-29 19:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

New review comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#discussion_r462518126

Comment:
Will fix for this and `wasmtime`, I just copied blindly from `ppsspp` which I will also fix in a minute then.
Edit: nvm, `ppsspp` has them all in `$wrksrc`

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (3 preceding siblings ...)
  2020-07-29 19:39 ` [PR REVIEW] " ifreund
@ 2020-08-06 20:23 ` Chocimier
  2020-08-06 23:55 ` [PR PATCH] [Updated] " ifreund
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2020-08-06 20:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#issuecomment-670173670

Comment:
Please add `make_check_target=check`, `checkdepends="python3-ply"` and gtest, testsuite submodules so tests can be run. Use d2163dace09d647bccf34b9b82a6f05a3b23cf29 version of testsuite, matching release.

On moving submodules, use commit hashes rather than globbing:
```
rmdir third_party/wasm-c-api
mv ../wasm-c-api-${_wasm_c_api_commit} third_party/wasm-c-api
```

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (4 preceding siblings ...)
  2020-08-06 20:23 ` Chocimier
@ 2020-08-06 23:55 ` ifreund
  2020-08-06 23:56 ` ifreund
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-08-06 23:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

There is an updated pull request by ifreund against master on the void-packages repository

https://github.com/ifreund/void-packages wabt
https://github.com/void-linux/void-packages/pull/23932

New package: wabt-1.0.19


A patch file from https://github.com/void-linux/void-packages/pull/23932.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wabt-23932.patch --]
[-- Type: text/x-diff, Size: 1908 bytes --]

From 195c6d594f36c5a78fdbf3bdedb7211128d17d2d Mon Sep 17 00:00:00 2001
From: Isaac Freund <ifreund@ifreund.xyz>
Date: Wed, 29 Jul 2020 20:44:39 +0200
Subject: [PATCH] New package: wabt-1.0.19

---
 srcpkgs/wabt/template | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 srcpkgs/wabt/template

diff --git a/srcpkgs/wabt/template b/srcpkgs/wabt/template
new file mode 100644
index 00000000000..241f5b7bcfe
--- /dev/null
+++ b/srcpkgs/wabt/template
@@ -0,0 +1,33 @@
+# Template file for 'wabt'
+pkgname=wabt
+version=1.0.19
+revision=1
+build_style=cmake
+make_check_target=check
+checkdepends="python3-ply"
+short_desc="WebAssembly Binary Toolkit"
+maintainer="Isaac Freund <ifreund@ifreund.xyz>"
+license="Apache-2.0"
+homepage="https://github.com/WebAssembly/wabt"
+_gtest_commit=7888184f28509dba839e3683409443e0b5bb8948
+_testsuite_commit=d2163dace09d647bccf34b9b82a6f05a3b23cf29
+_wasm_c_api_commit=d9a80099d496b5cdba6f3fe8fc77586e0e505ddc
+distfiles="https://github.com/WebAssembly/wabt/archive/${version}.tar.gz
+ https://github.com/google/googletest/archive/${_gtest_commit}.tar.gz
+ https://github.com/WebAssembly/testsuite/archive/${_testsuite_commit}.tar.gz
+ https://github.com/WebAssembly/wasm-c-api/archive/${_wasm_c_api_commit}.tar.gz"
+checksum="134f2afc8205d0a3ab89c5f0d424ff3823e9d2769c39d2235aa37eba7abc15ba
+ acc72b0cde04828fd4640576fdbd0727fc202f08b7701ae0bb318e2510f44b22
+ 1ea206dba1b0826cf52e7a4b9328a341c75e8642072ab5e34356def380ad504d
+ aea8cd095e9937f1e14f2c93e026317b197eb2345e7a817fe3932062eb7b792c"
+
+pre_configure() {
+	# move submodule to proper location
+	rmdir third_party/gtest
+	rmdir third_party/testsuite
+	rmdir third_party/wasm-c-api
+
+	mv -v ../googletest-${_gtest_commit} third_party/gtest
+	mv -v ../testsuite-${_testsuite_commit} third_party/testsuite
+	mv -v ../wasm-c-api-${_wasm_c_api_commit} third_party/wasm-c-api
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (5 preceding siblings ...)
  2020-08-06 23:55 ` [PR PATCH] [Updated] " ifreund
@ 2020-08-06 23:56 ` ifreund
  2020-08-06 23:57 ` ifreund
  2020-08-07 19:16 ` [PR PATCH] [Merged]: " Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-08-06 23:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#issuecomment-670247667

Comment:
@Chocimier Thanks for the review, made the suggested changes. Needed to add the testsuite submodule as well to get the tests passing.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (6 preceding siblings ...)
  2020-08-06 23:56 ` ifreund
@ 2020-08-06 23:57 ` ifreund
  2020-08-07 19:16 ` [PR PATCH] [Merged]: " Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: ifreund @ 2020-08-06 23:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New comment by ifreund on void-packages repository

https://github.com/void-linux/void-packages/pull/23932#issuecomment-670247667

Comment:
@Chocimier Thanks for the review, made the suggested changes.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: New package: wabt-1.0.19
  2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
                   ` (7 preceding siblings ...)
  2020-08-06 23:57 ` ifreund
@ 2020-08-07 19:16 ` Chocimier
  8 siblings, 0 replies; 10+ messages in thread
From: Chocimier @ 2020-08-07 19:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

There's a merged pull request on the void-packages repository

New package: wabt-1.0.19
https://github.com/void-linux/void-packages/pull/23932

Description:


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-08-07 19:16 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 18:45 [PR PATCH] New package: wabt-1.0.19 ifreund
2020-07-29 18:52 ` [PR REVIEW] " Chocimier
2020-07-29 18:57 ` ifreund
2020-07-29 19:21 ` [PR PATCH] [Updated] " ifreund
2020-07-29 19:39 ` [PR REVIEW] " ifreund
2020-08-06 20:23 ` Chocimier
2020-08-06 23:55 ` [PR PATCH] [Updated] " ifreund
2020-08-06 23:56 ` ifreund
2020-08-06 23:57 ` ifreund
2020-08-07 19:16 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).