From: Noah-Huppert <Noah-Huppert@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] xbps-src: fixed dangling binpkg lock on error
Date: Mon, 10 Aug 2020 17:37:25 +0200 [thread overview]
Message-ID: <20200810153725.n0sUFcGFTCVNESbbQaHr9IrW8oP3pwl1H75ymUyJ4l8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24191@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
New review comment by Noah-Huppert on void-packages repository
https://github.com/void-linux/void-packages/pull/24191#discussion_r467994688
Comment:
Yea I think you're right. I modified the trap function so it checks to see if the lock file exists before deleting it. This allowed me to move the trap to before the lock file is created and the untrap to after the file is removed. This should cover all the bases, including if the lock file fails to be created or removed.
next prev parent reply other threads:[~2020-08-10 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 6:01 [PR PATCH] " Noah-Huppert
2020-08-10 6:03 ` [PR PATCH] [Updated] " Noah-Huppert
2020-08-10 6:04 ` Noah-Huppert
2020-08-10 6:20 ` [PR REVIEW] " Noah-Huppert
2020-08-10 6:29 ` [PR PATCH] [Updated] " Noah-Huppert
2020-08-10 6:30 ` Noah-Huppert
2020-08-10 6:33 ` Noah-Huppert
2020-08-10 6:34 ` [PR REVIEW] " Noah-Huppert
2020-08-10 15:28 ` Noah-Huppert
2020-08-10 15:33 ` ahesford
2020-08-10 15:35 ` [PR PATCH] [Updated] " Noah-Huppert
2020-08-10 15:37 ` Noah-Huppert [this message]
2020-08-10 15:51 ` ahesford
2020-08-10 16:47 ` [PR PATCH] [Updated] " Noah-Huppert
2020-08-10 16:47 ` Noah-Huppert
2020-08-17 13:42 ` [PR PATCH] [Closed]: " ahesford
2020-08-17 13:45 ` ahesford
2020-08-19 20:33 ` Noah-Huppert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810153725.n0sUFcGFTCVNESbbQaHr9IrW8oP3pwl1H75ymUyJ4l8@z \
--to=noah-huppert@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).