Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] network-ups-tools: do not ship binaries in /var
@ 2020-08-14  2:38 CameronNemo
  2020-08-14  2:50 ` ahesford
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: CameronNemo @ 2020-08-14  2:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

There is a new pull request by CameronNemo against master on the void-packages repository

https://github.com/CameronNemo/void-packages NUT
https://github.com/void-linux/void-packages/pull/24265

network-ups-tools: do not ship binaries in /var
In Debian these are shipped in /lib/nut,
which is equivalent to /usr/libexec/nut on Void.

Binaries certainly do not belong in /var.

A patch file from https://github.com/void-linux/void-packages/pull/24265.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-NUT-24265.patch --]
[-- Type: text/x-diff, Size: 1451 bytes --]

From e3763ceff377b16cf337528d782ee2652d8bdd92 Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Thu, 13 Aug 2020 19:36:13 -0700
Subject: [PATCH] network-ups-tools: do not ship binaries in /var

In Debian these are shipped in /lib/nut,
which is equivalent to /usr/libexec/nut on Void.

Binaries certainly do not belong in /var.
---
 srcpkgs/network-ups-tools/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/network-ups-tools/template b/srcpkgs/network-ups-tools/template
index 6582e8d3f9b..cc100bbde6e 100644
--- a/srcpkgs/network-ups-tools/template
+++ b/srcpkgs/network-ups-tools/template
@@ -1,7 +1,7 @@
 # Template file for 'network-ups-tools'
 pkgname=network-ups-tools
 version=2.7.4
-revision=9
+revision=10
 wrksrc="nut-${version}"
 build_style=gnu-configure
 configure_args="
@@ -9,7 +9,7 @@ configure_args="
  --datadir=/usr/share/ups --with-user=nut --with-group=nut --with-ssl
  --with-usb --with-dev --with-serial -with-avahi --with-udev-dir=/usr/lib/udev
  --with-libltdl --without-ipmi --without-freeipmi --without-systemdsystemunitdir
- --with-snmp --with-drvpath=/var/lib/nut $(vopt_with cgi) --with-statepath=/run/ups"
+ --with-snmp --with-drvpath=/usr/libexec/nut $(vopt_with cgi) --with-statepath=/run/ups"
 hostmakedepends="pkg-config"
 makedepends="avahi-libs-devel libressl-devel libusb-compat-devel neon-devel
  net-snmp-devel $(vopt_if cgi gd-devel) libltdl-devel"

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: network-ups-tools: do not ship binaries in /var
  2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
@ 2020-08-14  2:50 ` ahesford
  2020-09-07 23:20 ` network-ups-tools: add warning about FHS violation ahesford
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-08-14  2:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24265#issuecomment-673853931

Comment:
I can't test this, but I like the idea.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: network-ups-tools: add warning about FHS violation
  2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
  2020-08-14  2:50 ` ahesford
@ 2020-09-07 23:20 ` ahesford
  2020-09-07 23:34 ` CameronNemo
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-07 23:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24265#issuecomment-688538017

Comment:
I've looked at the source code and see no reason why `/usr/libexec/nut` would behave any differently than `/var/lib/nut`. Furthremore, this uses a flag provided directly by the configure script, so we can probably have faith that upstream has tested the path specification mechanism. I'm content to merge your original patch at e3763ce if you don't object, knowing we can always revert the change if somebody reports an issue.

If you don't want the blame for this change, I'll merge an equivalent change in my own name. Let me know what you prefer.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: network-ups-tools: add warning about FHS violation
  2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
  2020-08-14  2:50 ` ahesford
  2020-09-07 23:20 ` network-ups-tools: add warning about FHS violation ahesford
@ 2020-09-07 23:34 ` CameronNemo
  2020-09-07 23:44 ` ahesford
  2020-09-07 23:44 ` [PR PATCH] [Closed]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: CameronNemo @ 2020-09-07 23:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24265#issuecomment-688540856

Comment:
I'll take the blame, I've broken more critical packages before :p.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: network-ups-tools: add warning about FHS violation
  2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
                   ` (2 preceding siblings ...)
  2020-09-07 23:34 ` CameronNemo
@ 2020-09-07 23:44 ` ahesford
  2020-09-07 23:44 ` [PR PATCH] [Closed]: " ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-07 23:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24265#issuecomment-688543396

Comment:
Merged in 3efc1561c72b58df693c939036b5b9b09d7c0d47

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: network-ups-tools: add warning about FHS violation
  2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
                   ` (3 preceding siblings ...)
  2020-09-07 23:44 ` ahesford
@ 2020-09-07 23:44 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-09-07 23:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

There's a closed pull request on the void-packages repository

network-ups-tools: add warning about FHS violation
https://github.com/void-linux/void-packages/pull/24265

Description:
In Debian these are shipped in /lib/nut,
which is equivalent to /usr/libexec/nut on Void.

Binaries certainly do not belong in /var.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-09-07 23:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14  2:38 [PR PATCH] network-ups-tools: do not ship binaries in /var CameronNemo
2020-08-14  2:50 ` ahesford
2020-09-07 23:20 ` network-ups-tools: add warning about FHS violation ahesford
2020-09-07 23:34 ` CameronNemo
2020-09-07 23:44 ` ahesford
2020-09-07 23:44 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).