From: cinerea0 <cinerea0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] sof-firmware: fix deadlinks in the package.
Date: Fri, 14 Aug 2020 16:06:50 +0200 [thread overview]
Message-ID: <20200814140650.GDqmGRkkt-c8ppo7DYgRvmPqtNY5pHq2sP38OziQCq8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24271@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#discussion_r470644779
Comment:
You still need to keep these three lines in the template somewhere because they create symlinks to files that don't match the original name. You should probably move them after the new for loop you created for clarity, though.
next prev parent reply other threads:[~2020-08-14 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 11:21 [PR PATCH] " Gottox
2020-08-14 13:41 ` ericonr
2020-08-14 14:06 ` cinerea0 [this message]
2020-08-14 14:09 ` cinerea0
2020-08-16 16:32 ` [PR REVIEW] " Gottox
2020-08-16 16:35 ` Gottox
2020-08-19 0:17 ` [PR REVIEW] " cinerea0
2020-08-19 2:07 ` cinerea0
2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814140650.GDqmGRkkt-c8ppo7DYgRvmPqtNY5pHq2sP38OziQCq8@z \
--to=cinerea0@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).