* [PR PATCH] sof-firmware: fix deadlinks in the package.
@ 2020-08-14 11:21 Gottox
2020-08-14 13:41 ` ericonr
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Gottox @ 2020-08-14 11:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
There is a new pull request by Gottox against master on the void-packages repository
https://github.com/Gottox/void-packages sof-firmware-fix-deadlinks
https://github.com/void-linux/void-packages/pull/24271
sof-firmware: fix deadlinks in the package.
A patch file from https://github.com/void-linux/void-packages/pull/24271.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-firmware-fix-deadlinks-24271.patch --]
[-- Type: text/x-diff, Size: 1513 bytes --]
From f9f9e3a574dd39d38a00bdc423d212a0710f109e Mon Sep 17 00:00:00 2001
From: Enno Boland <gottox@voidlinux.org>
Date: Fri, 14 Aug 2020 13:20:25 +0200
Subject: [PATCH] sof-firmware: fix deadlinks in the package.
---
srcpkgs/sof-firmware/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..61737fe34a0 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,7 +1,7 @@
# Template file for 'sof-firmware'
pkgname=sof-firmware
version=1.5.1
-revision=1
+revision=2
archs="i686* x86_64*"
wrksrc=sof-bin-stable-v${version}
short_desc="Sound Open Firmware and topology binaries"
@@ -22,12 +22,12 @@ do_install() {
for f in ${intel_path}/sof/v${version}/public-signed/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
done
- for arc in {bdw,byt,cht,apl,cnl,icl}; do
+ for arc in {bdw,byt,cht}; do
ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
done
- ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
- ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+ for arc in {apl,cnl,icl}; do
+ ln -s intel-signed/sof-$arc-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-$arc.ri
+ done
for f in ${intel_path}/sof-tplg-v${version}/*; do
vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
done
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
@ 2020-08-14 13:41 ` ericonr
2020-08-14 14:06 ` [PR REVIEW] " cinerea0
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-08-14 13:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 151 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#issuecomment-674080712
Comment:
@cinerea0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
2020-08-14 13:41 ` ericonr
@ 2020-08-14 14:06 ` cinerea0
2020-08-14 14:09 ` cinerea0
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2020-08-14 14:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#discussion_r470644779
Comment:
You still need to keep these three lines in the template somewhere because they create symlinks to files that don't match the original name. You should probably move them after the new for loop you created for clarity, though.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
2020-08-14 13:41 ` ericonr
2020-08-14 14:06 ` [PR REVIEW] " cinerea0
@ 2020-08-14 14:09 ` cinerea0
2020-08-16 16:32 ` [PR REVIEW] " Gottox
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2020-08-14 14:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#issuecomment-674093374
Comment:
I've left a review requesting changes that keep a few symlinks that don't follow the pattern of the others. Thank you for finding and fixing my mistake, Gottox.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
` (2 preceding siblings ...)
2020-08-14 14:09 ` cinerea0
@ 2020-08-16 16:32 ` Gottox
2020-08-16 16:35 ` Gottox
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Gottox @ 2020-08-16 16:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 184 bytes --]
New review comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#discussion_r471132186
Comment:
Ah, I see. Where are those files used?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
` (3 preceding siblings ...)
2020-08-16 16:32 ` [PR REVIEW] " Gottox
@ 2020-08-16 16:35 ` Gottox
2020-08-19 0:17 ` [PR REVIEW] " cinerea0
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Gottox @ 2020-08-16 16:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New comment by Gottox on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#issuecomment-674548221
Comment:
btw, while we're at it. I'm not sure if we rather should use the intel signed or the public signed firmwares by default
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR REVIEW] sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
` (4 preceding siblings ...)
2020-08-16 16:35 ` Gottox
@ 2020-08-19 0:17 ` cinerea0
2020-08-19 2:07 ` cinerea0
2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2020-08-19 0:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
New review comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#discussion_r472563159
Comment:
For some reason, certain machines look for differently-named firmware than they should be looking for. For example, on my laptop, even though it should be looking for `sof-cnl.ri` (the Cannon Lake firmware), it looks for `sof-cml.ri`.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
` (5 preceding siblings ...)
2020-08-19 0:17 ` [PR REVIEW] " cinerea0
@ 2020-08-19 2:07 ` cinerea0
2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
7 siblings, 0 replies; 9+ messages in thread
From: cinerea0 @ 2020-08-19 2:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 414 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/24271#issuecomment-675809345
Comment:
@Gottox Do you mean excluding either the public or intel signed firmwares from the package and providing the excluded one as a sub-package or something? If that's the case, it might be useful to know that there's one more intel signed firmware than there is public signed.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Closed]: sof-firmware: fix deadlinks in the package.
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
` (6 preceding siblings ...)
2020-08-19 2:07 ` cinerea0
@ 2020-12-10 18:48 ` ericonr
7 siblings, 0 replies; 9+ messages in thread
From: ericonr @ 2020-12-10 18:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
There's a closed pull request on the void-packages repository
sof-firmware: fix deadlinks in the package.
https://github.com/void-linux/void-packages/pull/24271
Description:
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-12-10 18:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 11:21 [PR PATCH] sof-firmware: fix deadlinks in the package Gottox
2020-08-14 13:41 ` ericonr
2020-08-14 14:06 ` [PR REVIEW] " cinerea0
2020-08-14 14:09 ` cinerea0
2020-08-16 16:32 ` [PR REVIEW] " Gottox
2020-08-16 16:35 ` Gottox
2020-08-19 0:17 ` [PR REVIEW] " cinerea0
2020-08-19 2:07 ` cinerea0
2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).