[PR PATCH] discord-ptb: update to 0.0.21

[PR PATCH] discord-ptb: update to 0.0.21

[chilledfrogs]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

There is a new pull request by chilledfrogs against master on the void-packages repository

https://github.com/chilledfrogs/void-packages master
https://github.com/void-linux/void-packages/pull/24276

discord-ptb: update to 0.0.21


A patch file from https://github.com/void-linux/void-packages/pull/24276.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24276.patch --]
[-- Type: text/x-diff, Size: 1234 bytes --]

From 806317f1912a10016bd303bb69d91c18ee06af7b Mon Sep 17 00:00:00 2001
From: Allen Sobot <chilledfrogs@disroot.org>
Date: Fri, 14 Aug 2020 18:45:58 +0200
Subject: [PATCH] discord-ptb: update to 0.0.21

---
 srcpkgs/discord-ptb/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/discord-ptb/template b/srcpkgs/discord-ptb/template
index 0485c222023..787e934b168 100644
--- a/srcpkgs/discord-ptb/template
+++ b/srcpkgs/discord-ptb/template
@@ -1,6 +1,6 @@
 # Template file for 'discord-ptb'
 pkgname="discord-ptb"
-version=0.0.9
+version=0.0.21
 revision=1
 wrksrc="DiscordPTB"
 depends="alsa-lib dbus-glib gtk+3 GConf libnotify nss libXtst libcxx libatomic"
@@ -11,9 +11,9 @@ restricted=yes
 short_desc="Proprietary freeware VoIP application"
 maintainer="Abel Graham <abel@abelgraham.com>"
 license="proprietary"
-homepage="https://discordapp.com/"
+homepage="https://discord.com/"
 distfiles="https://dl-ptb.discordapp.net/apps/linux/${version}/discord-ptb-${version}.tar.gz"
-checksum=372d6f75203626370218c97c21519b779e5af334177cafa65a5655e357c77520
+checksum=a1fa4e20cce5f493d84c9e3c7ac74c8265768886859e98022fa41d102f2726c4
 
 do_install() {
 	local package_location="usr/lib/$pkgname" item

Re: discord-ptb: update to 0.0.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24276#issuecomment-674167230

Comment:
Duplicate of #24117 

Re: discord-ptb: update to 0.0.21

[chilledfrogs]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by chilledfrogs on void-packages repository

https://github.com/void-linux/void-packages/pull/24276#issuecomment-674169694

Comment:
Whoops, really sorry, didn't see it before and only got around to attempting to do it now (and failing it seems :sweat_smile:

Re: [PR PATCH] [Closed]: discord-ptb: update to 0.0.21

[chilledfrogs]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

There's a closed pull request on the void-packages repository

discord-ptb: update to 0.0.21
https://github.com/void-linux/void-packages/pull/24276

Description:

Re: discord-ptb: update to 0.0.21

[chilledfrogs]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by chilledfrogs on void-packages repository

https://github.com/void-linux/void-packages/pull/24276#issuecomment-674169694

Comment:
Whoops, really sorry, didn't see it before and only got around to attempting to do it now (and failing it seems :sweat_smile:)

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24276#issuecomment-674186577

Comment:
You're good ;) I've been waiting a while for a merge myself.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-690116845

Comment:
Should commit message contain every change or just the "discord-ptb: update to 0.0.22"?

Re: discord-ptb: update to 0.0.21

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-690116231

Comment:
No, you should just change the commit message and the title.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-690070729

Comment:
I've updated the package to 0.0.22.
Should I close this PR and create a new one, as the version changed or would it be ok, if I just changed the commit message and PR's title?

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-677944274

Comment:
> BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)

I've just updated the URL.

Re: discord-ptb: update to 0.0.21

[chilledfrogs]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

New comment by chilledfrogs on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-677942795

Comment:
BTW, just a little detail, but they moved to https://discord.com/ recently-ish @MGlolenstine, might wanna update that in homepage (for the moment the old URL is still usable though so not a huge deal)

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-674192934

Comment:
This seems better.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-674191304

Comment:
Ugh... I guess that squash didn't work like I wanted it to. :sweat_smile: 

Re: discord-ptb: update to 0.0.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-674187140

Comment:
You need to squash these commits before it can be merged.

Re: discord-ptb: update to 0.0.21

[FirstZero]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by FirstZero on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-671533939

Comment:
Ideally you might want to squash rebase your commits into one. Other than that, this seems ready for review.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-671178770

Comment:
Would this be ready for merge, or is there something still missing?

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670960105

Comment:
> I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.

Oh wow, that looks complicated... It's pretty late here, so I'll take my time tomorrow and modify it... 

Re: discord-ptb: update to 0.0.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959734

Comment:
I think that file would work, but you'd have to do something like https://github.com/void-linux/void-packages/blob/master/srcpkgs/spotify/template#L23 to pre-process it.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959555

Comment:
> You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.

Would this do? 
How should I format it in the file? 
```
vlicense=https://discord.com/terms
```

Re: discord-ptb: update to 0.0.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670959395

Comment:
You might need to find an EULA or License Agreement. The spotify template, for example, has to do a similar dance.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670955236

Comment:
@ericonr This is the lint error I was talking about. I'm unsure what to put at the `vlicense` if anything.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670729485

Comment:
I think "custom:Proprietary" had some problems with xlint and was throwing errors... I'll have to check out that tomorrow (it's midnight here) and I'm in for 80 char line wrap.

Re: discord-ptb: update to 0.0.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670727828

Comment:
I believe "custom:Proprietary" is preferred. And line wraps around 80 columns, if possible.

Re: discord-ptb: update to 0.0.21

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670724491

Comment:
The `custom:` speciefier indicates it is not SPDX. Use something along the lines of `custom:proprietary`.

The line wrap looks good, but maybe make it consistent. I.e., if you are going to split at (I think you did) 90 characters, split the next line at 90 characters too... keep all of the lines for that block the same length.

Eg:

```
	for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
	libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin swiftshader v8_context_snapshot.bin; do
```
to

```
	for item in DiscordPTB chrome_100_percent.pak chrome_200_percent.pak icudtl.dat libEGL.so \
	libGLESv2.so libffmpeg.so locales natives_blob.bin resources resources.pak snapshot_blob.bin \
        swiftshader v8_context_snapshot.bin; do
```

Re: discord-ptb: update to 0.0.21

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670724491

Comment:
The `custom:` speciefier indicates it is not SPDX. Use something along the lines of `custom:proprietary`.

The line wrap looks good, but maybe make it consistent. I.e., if you are going to split at (I think you did) 90 characters, split the next line at 90 characters too... keep all of the lines for that block the same length.

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291

Comment:
On it!

EDIT: I've been trying to find a license Discord uses, but was unable to.
it's set as "proprietary" in the file, but no SPDX is set. Now I've found this https://discord.com/terms , but I'm unsure on how to add it to the file.
[Here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables) it states that it can be a `Public Domain`. Does that mean that I can just insert the URL from above and we're set?

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291

Comment:
On it!

EDIT: I've been trying to find a license Discord uses, but was unable to.
it's set as "proprietary" in the file, but no SPDX is set. Now I've found this https://discord.com/terms , but I'm unsure on how to add it to the file.
[Here](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory-variables) it states that it can be a `Public Domain`. Does that mean, that I can just insert the URL from above and we're set?

Re: discord-ptb: update to 0.0.21

[MGlolenstine]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New comment by MGlolenstine on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670398291

Comment:
On it!

Re: discord-ptb: update to 0.0.21

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24117#issuecomment-670250561

Comment:
Thanks for your PR!

https://travis-ci.org/github/void-linux/void-packages/jobs/715664522 as you can see here, there are some `xlint` erorrs. Would you mind fixing them?