From: mnabid <mnabid@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] rhythmbox: optionalise brasero
Date: Sun, 16 Aug 2020 12:52:24 +0200 [thread overview]
Message-ID: <20200816105224.dvt6SIAU2Sc-hMEp-P2Pvzg-NMaRKz2WKGw4rp9JbwY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22700@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
There is an updated pull request by mnabid against master on the void-packages repository
https://github.com/mnabid/void-packages rhythmbox
https://github.com/void-linux/void-packages/pull/22700
rhythmbox: optionalise brasero
This PR adds a `build_option` for brasero and disables it by default.
Note, `rhythmbox` from both [**Ubuntu**](https://packages.ubuntu.com/groovy/rhythmbox) and [**Debian**](https://packages.debian.org/sid/rhythmbox) repos doesn't have `brasero` as dependency. [**Arch Linux**](https://www.archlinux.org/packages/extra/x86_64/rhythmbox/) lists `brasero` as an optional dependency. But the one from Void repo pulls down `brasero` as hard dependency, which shouldn't be the case.
A patch file from https://github.com/void-linux/void-packages/pull/22700.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhythmbox-22700.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]
From 7d865c0fc3da723404761518603ec597927e9cb5 Mon Sep 17 00:00:00 2001
From: Nafis <mnabid.25@outlook.com>
Date: Mon, 6 Jul 2020 14:58:45 +0600
Subject: [PATCH] rhythmbox: optionalise brasero
---
srcpkgs/rhythmbox/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/rhythmbox/template b/srcpkgs/rhythmbox/template
index bd3a56f6359..27c9a4f645a 100644
--- a/srcpkgs/rhythmbox/template
+++ b/srcpkgs/rhythmbox/template
@@ -1,7 +1,7 @@
# Template file for 'rhythmbox'
pkgname=rhythmbox
version=3.4.4
-revision=2
+revision=3
build_style=gnu-configure
build_helper=gir
configure_args="--disable-static --with-gudev --without-hal
@@ -11,7 +11,7 @@ hostmakedepends="pkg-config intltool gnome-doc-utils itstool glib-devel
$(vopt_if gir 'gobject-introspection vala')"
makedepends="gtk+3-devel libsoup-gnome-devel totem-pl-parser-devel
json-glib-devel libgudev-devel libdiscid-devel vala-devel
- libmtp-devel avahi-glib-libs-devel libpeas-devel brasero-devel
+ libmtp-devel avahi-glib-libs-devel libpeas-devel $(vopt_if brasero brasero-devel)
libnotify-devel tdb-devel libsecret-devel libSM-devel grilo-devel
gst-plugins-base1-devel clutter-gtk-devel python3-devel python-gobject-devel
libdmapsharing-devel"
@@ -26,7 +26,8 @@ checksum=ee0eb0d7d7bdf696ac9471b19ff3bea3240d63b6cb8a134bf632054af8665d90
python_version=3
pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
-build_options="gir"
+build_options="gir brasero"
+desc_option_brasero="Enable CD burning support"
build_options_default="gir"
pre_build() {
next prev parent reply other threads:[~2020-08-16 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-22700@inbox.vuxu.org>
2020-07-06 9:02 ` [WIP] [Help needed] " mnabid
2020-08-15 23:11 ` [PR REVIEW] " Piraty
2020-08-16 10:52 ` mnabid [this message]
2020-08-16 10:54 ` mnabid
2020-08-16 10:56 ` mnabid
2020-08-16 18:32 ` [PR PATCH] [Merged]: " Piraty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816105224.dvt6SIAU2Sc-hMEp-P2Pvzg-NMaRKz2WKGw4rp9JbwY@z \
--to=mnabid@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).