From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Manual.md: revamp explain_depends section.
Date: Sun, 16 Aug 2020 17:27:08 +0200 [thread overview]
Message-ID: <20200816152708.xwjzSqyNtbkk9S0vytm4z4SeRBljD9oCQdp7q6u_YOg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23746@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 459 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23746#discussion_r471125754
Comment:
`dbus` is necessary for running tests which require D-Bus, and it isn't obvious that `dbus-run-session` can be called from inside the `do_check` stage, because the tests only complain about a lack of D-Bus. Mostly want to avoid people having to cargo cult and instead be able to read the Manual to figure it out.
next prev parent reply other threads:[~2020-08-16 15:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 19:38 [PR PATCH] " ericonr
2020-07-22 19:40 ` [PR PATCH] [Updated] " ericonr
2020-07-22 20:51 ` ericonr
2020-08-16 12:41 ` [PR REVIEW] " Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 12:41 ` Piraty
2020-08-16 15:17 ` ericonr
2020-08-16 15:23 ` ericonr
2020-08-16 15:27 ` ericonr [this message]
2020-08-16 15:29 ` [PR PATCH] [Updated] " ericonr
2020-11-22 5:09 ` [PR PATCH] [Merged]: " the-maldridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816152708.xwjzSqyNtbkk9S0vytm4z4SeRBljD9oCQdp7q6u_YOg@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).