Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] freexl: update to 1.0.6.
Date: Mon, 17 Aug 2020 01:48:19 +0200	[thread overview]
Message-ID: <20200816234819.fPURMi5SeIqx4xQY5mY-t0-FeyF2JjEq52rIxljR5ag@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24067@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24067#discussion_r471174962

Comment:
In practice it probably doesn't matter much, but `>=` is best practice.

Holding the `-devel` package while still upgrading `${sourcepkg}` will, for example, still allow local static linking against an old version without risking breakage of dependants of `${sourceppkg}`. Sure, this is a contrived example, but why prohibit this behavior for no real benefit?

  parent reply	other threads:[~2020-08-16 23:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05  9:44 [PR PATCH] " fosslinux
2020-08-10 11:38 ` [PR REVIEW] " Piraty
2020-08-10 11:38 ` Piraty
2020-08-15 21:59 ` [PR PATCH] [Updated] " fosslinux
2020-08-15 21:59 ` fosslinux
2020-08-15 22:02 ` [PR REVIEW] " ericonr
2020-08-16  0:17 ` fosslinux
2020-08-16  8:06 ` [PR PATCH] [Updated] " fosslinux
2020-08-16  9:43 ` [PR REVIEW] " Piraty
2020-08-16 23:48 ` ahesford [this message]
2020-08-17 23:23 ` fosslinux
2020-08-17 23:23 ` fosslinux
2020-08-19  6:06 ` [PR PATCH] [Updated] " fosslinux
2020-08-19  6:07 ` [PR REVIEW] " fosslinux
2020-08-19 11:11 ` [PR PATCH] [Merged]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200816234819.fPURMi5SeIqx4xQY5mY-t0-FeyF2JjEq52rIxljR5ag@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).