From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: base-files: vkpurge: fix parameter expansion in list_kernels()
Date: Mon, 17 Aug 2020 02:46:47 +0200 [thread overview]
Message-ID: <20200817004647.ovlfklhAZJsXokiZyjQgTOaa6hBigAmkacDLQckzQCE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24298@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24298#issuecomment-674603122
Comment:
The `vkpurge` script exists to remove files orphaned by official Void kernel packages. What Void kernel ships with names of the form `vmlinu[xz]--next-`?
Correct functionality requires that kernel names take the form `/boot/vmlinu[xz]-$(uname -r)` and that `uname -r` also have the same form as `${k##*-}`. In practice, Void only ships kernels where `$(uname -r)` does not contain hyphens, so `vkpurge` works as expected in its current form. If Void were ever to ship kernels with a `LOCALVERSION` that contained a hyphenated suffix, your change would probably be sufficient to handle those kernels. If Void were to differentiate kernels based on some prefix that does not get incorporated into kernel versioning (for example, `vmlinuz-lts-5.7.15_1` for `$(uname -r) = 5.7.15_1`, the entire `vkpurge` behavior would need to be rethought.
next prev parent reply other threads:[~2020-08-17 0:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 19:51 [PR PATCH] " avoidr
2020-08-15 19:58 ` ericonr
2020-08-15 21:12 ` avoidr
2020-08-15 21:15 ` [PR PATCH] [Updated] " avoidr
2020-08-17 0:46 ` ahesford [this message]
2020-08-18 20:33 ` q66
2020-08-18 20:46 ` ahesford
2020-08-19 0:32 ` avoidr
2020-08-19 0:52 ` ahesford
2020-08-19 1:02 ` [PR PATCH] [Closed]: " ahesford
2020-08-19 1:45 ` avoidr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817004647.ovlfklhAZJsXokiZyjQgTOaa6hBigAmkacDLQckzQCE@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).