From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] xbps-src/update_check: add codeberg support
Date: Mon, 17 Aug 2020 12:39:18 +0200 [thread overview]
Message-ID: <20200817103918.BJUsGP86e60qvRvGXHZ483mdyQfalTLKDZW-G6PA_5I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24317@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/24317#discussion_r471392315
Comment:
codebergname should be declared local.
Better yet, there should be one variable, say, `siteurlname`, instead of sfname, lpname, and so on. Commit separately if you feel like.
next prev parent reply other threads:[~2020-08-17 10:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:24 [PR PATCH] " ifreund
2020-08-17 9:30 ` ifreund
2020-08-17 10:39 ` [PR REVIEW] " Chocimier
2020-08-17 10:39 ` Chocimier [this message]
2020-08-17 10:52 ` [PR PATCH] [Updated] " ifreund
2020-08-17 10:53 ` [PR REVIEW] " ifreund
2020-08-18 12:46 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817103918.BJUsGP86e60qvRvGXHZ483mdyQfalTLKDZW-G6PA_5I@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).