From: avoidr <avoidr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: base-files: vkpurge: fix parameter expansion in list_kernels()
Date: Wed, 19 Aug 2020 02:32:03 +0200 [thread overview]
Message-ID: <20200819003203.03nI6sL0sN_w7pRUz25eWB6wZpBbygsAGw_57c4FoV4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24298@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
New comment by avoidr on void-packages repository
https://github.com/void-linux/void-packages/pull/24298#issuecomment-675784741
Comment:
The problem I found was that vkpurge listed my kernel with the -next- part stripped, and that string couldn't be used to remove the kernel with vkpurge.
In the script I saw that the files are matched against "vmlinu[xz]-*", with no mention of any other hyphens. So ${k##*-} seemed problematic, because it might expand to further hyphens that we don't know of. It simply seemed like an oversight to me.
Void doesn't currently prefix any kernels with anything, so this change doesn't affect "official" kernels, but it expands to manually installed kernels. Or is that not right?
next prev parent reply other threads:[~2020-08-19 0:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 19:51 [PR PATCH] " avoidr
2020-08-15 19:58 ` ericonr
2020-08-15 21:12 ` avoidr
2020-08-15 21:15 ` [PR PATCH] [Updated] " avoidr
2020-08-17 0:46 ` ahesford
2020-08-18 20:33 ` q66
2020-08-18 20:46 ` ahesford
2020-08-19 0:32 ` avoidr [this message]
2020-08-19 0:52 ` ahesford
2020-08-19 1:02 ` [PR PATCH] [Closed]: " ahesford
2020-08-19 1:45 ` avoidr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819003203.03nI6sL0sN_w7pRUz25eWB6wZpBbygsAGw_57c4FoV4@z \
--to=avoidr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).