From: gt7-void <gt7-void@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mdocml: backport patches for #9868
Date: Sun, 23 Aug 2020 23:58:03 +0200 [thread overview]
Message-ID: <20200823215803.n7oyHz3D3pkSVgQ2UjekpsPHi1cwqIgnJEEb6FPuXyI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23108@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]
New review comment by gt7-void on void-packages repository
https://github.com/void-linux/void-packages/pull/23108#discussion_r475272167
Comment:
I just took the chance to make some (mostly) noop changes to the template to make xlint happy. The proposed commit fixes all of the following warnings in the current template:
```
$ xlint srcpkgs/mdocml/template
srcpkgs/mdocml/template: Place checkdepends= after depends=
srcpkgs/mdocml/template: Place provides= after checksum=
srcpkgs/mdocml/template:14: short_desc should not start with an article
srcpkgs/mdocml/template:33: trailing whitespace
srcpkgs/mdocml/template:40: custom variables should use _ prefix: PREFIX=/usr
srcpkgs/mdocml/template:41: custom variables should use _ prefix: SBINDIR=/usr/bin
srcpkgs/mdocml/template:42: custom variables should use _ prefix: MANDIR=/usr/share/man
srcpkgs/mdocml/template:43: custom variables should use _ prefix: OSNAME="Void Linux"
srcpkgs/mdocml/template:44: custom variables should use _ prefix: BINM_SOELIM=mandoc-soelim
srcpkgs/mdocml/template:45: custom variables should use _ prefix: MANM_ROFF="mandoc_roff"
srcpkgs/mdocml/template:49: custom variables should use _ prefix: HAVE_REWB_BSD=0
srcpkgs/mdocml/template:54: trailing whitespace
```
What's the recommended way to fix the warnings for lines 40-49?
The `-` means to strip leading tab characters (https://www.gnu.org/software/bash/manual/html_node/Redirections.html#Here-Documents)
Several templates use this pattern of indented heredoc (for one example see the git template).
I think the indented version is easier to read (either with two tabs or just one tab as in the git template) but I don't really care either way.
next prev parent reply other threads:[~2020-08-23 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23108@inbox.vuxu.org>
2020-08-23 20:25 ` Duncaen
2020-08-23 21:58 ` gt7-void [this message]
2020-09-29 2:15 ` ericonr
2020-09-29 2:54 ` ericonr
2020-09-29 5:50 ` [PR REVIEW] " ericonr
2020-10-02 14:11 ` leahneukirchen
2020-10-02 15:07 ` [PR REVIEW] " gt7-void
2020-10-14 11:41 ` Piraty
2020-11-25 16:58 ` ericonr
2020-12-22 19:43 ` [PR PATCH] [Closed]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823215803.n7oyHz3D3pkSVgQ2UjekpsPHi1cwqIgnJEEb6FPuXyI@z \
--to=gt7-void@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).