Github messages for voidlinux
 help / color / mirror / Atom feed
From: harrisonthorne <harrisonthorne@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] MPV MPRIS plugin fix
Date: Mon, 24 Aug 2020 20:37:54 +0200	[thread overview]
Message-ID: <20200824183754.AlLi6eM3wdk41asITOusbDMxCEXHgjqovbCJ8fpxxTQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24285@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

There is an updated pull request by harrisonthorne against master on the void-packages repository

https://github.com/harrisonthorne/void-packages mpv-mpris-fix
https://github.com/void-linux/void-packages/pull/24285

MPV MPRIS plugin fix
mpv and the mpv-mpris plugin weren't working together out-of-the-box for me, so these edits fix that.

I've confirmed on my end that these changes work :)

The changes made are based on the documentation for mpv-mpris [here](https://github.com/hoyon/mpv-mpris).

A patch file from https://github.com/void-linux/void-packages/pull/24285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpv-mpris-fix-24285.patch --]
[-- Type: text/x-diff, Size: 2317 bytes --]

From 8042f9ad2ae5f19c5850dfeaa15f88c4532f1088 Mon Sep 17 00:00:00 2001
From: Harrison Thorne <harrisonthorne@protonmail.com>
Date: Fri, 14 Aug 2020 17:47:42 -0600
Subject: [PATCH 1/2] mpv: Add --enable-cplugins config option

This change is part of an effort to fix integration between MPV and its
MPRIS plugin.
---
 srcpkgs/mpv/template | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index 598624e8949..9535ecc048b 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,15 +1,15 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.32.0
-revision=3
+revision=4
 build_style=waf3
 configure_args="--confdir=/etc/mpv --docdir=/usr/share/examples/mpv
  --enable-dvdnav --enable-cdda --enable-libmpv-shared
- --enable-dvbin --enable-libarchive $(vopt_enable alsa) $(vopt_enable caca)
- $(vopt_enable jack) $(vopt_enable lua) $(vopt_enable oss oss-audio)
- $(vopt_enable pulseaudio pulse) $(vopt_enable sdl2)
- $(vopt_enable smb libsmbclient) $(vopt_enable sndio)
- $(vopt_enable vapoursynth) $(vopt_enable vdpau) $(vopt_enable wayland)
+ --enable-dvbin --enable-libarchive --enable-cplugins $(vopt_enable alsa)
+ $(vopt_enable caca) $(vopt_enable jack) $(vopt_enable lua) 
+ $(vopt_enable oss oss-audio) $(vopt_enable pulseaudio pulse) 
+ $(vopt_enable sdl2) $(vopt_enable smb libsmbclient) $(vopt_enable sndio) 
+ $(vopt_enable vapoursynth) $(vopt_enable vdpau) $(vopt_enable wayland) 
  $(vopt_enable x11) $(vopt_enable vulkan) $(vopt_enable vulkan shaderc)"
 hostmakedepends="pkg-config python3-docutils perl $(vopt_if wayland wayland-devel)"
 makedepends="MesaLib-devel ffmpeg-devel harfbuzz-devel lcms2-devel libXv-devel

From 82f6dc269a6f28da770fda48d596e6940e03ebe0 Mon Sep 17 00:00:00 2001
From: Harrison Thorne <harrisonthorne@protonmail.com>
Date: Mon, 24 Aug 2020 12:37:10 -0600
Subject: [PATCH 2/2] mpv-mpris: vdoc README.md

---
 srcpkgs/mpv-mpris/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/mpv-mpris/template b/srcpkgs/mpv-mpris/template
index 774c21c5965..edfa832fcce 100644
--- a/srcpkgs/mpv-mpris/template
+++ b/srcpkgs/mpv-mpris/template
@@ -18,4 +18,5 @@ do_install() {
 	vlicense LICENSE
 	vmkdir usr/lib/${pkgname}
 	vinstall mpris.so 0644 usr/lib/${pkgname}
+    vdoc README.md
 }

  parent reply	other threads:[~2020-08-24 18:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15  0:09 [PR PATCH] " harrisonthorne
2020-08-15  0:39 ` [PR REVIEW] " ericonr
2020-08-15  1:18 ` flexibeast
2020-08-22 19:12 ` harrisonthorne
2020-08-22 20:38 ` ericonr
2020-08-24 18:37 ` harrisonthorne [this message]
2020-08-24 18:40 ` [PR PATCH] [Updated] " harrisonthorne
2020-08-24 18:43 ` [PR REVIEW] " harrisonthorne
2020-08-24 19:23 ` ericonr
2021-02-11  2:05 ` ericonr
2021-02-11  2:05 ` [PR PATCH] [Closed]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824183754.AlLi6eM3wdk41asITOusbDMxCEXHgjqovbCJ8fpxxTQ@z \
    --to=harrisonthorne@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).