From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] popt: update to 1.18.
Date: Mon, 24 Aug 2020 21:59:58 +0200 [thread overview]
Message-ID: <20200824195958.zmDU-hLutUSLX_HtgJw51orrgXkD_du2i3ecRRvFyOE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24436@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 496 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24436#discussion_r475859325
Comment:
I'm not thrilled about this Github release page serving as the changelog, not least because it will get out of sync if somebody forgets to update the version and we generally don't want to replace the static version with `$version` or anything like that. Might be better just to drop the changelog until upstream updates the in-repo `CHANGES` file.
next prev parent reply other threads:[~2020-08-24 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 15:56 [PR PATCH] " mobinmob
2020-08-24 19:59 ` ahesford [this message]
2020-08-24 20:00 ` [PR REVIEW] " ahesford
2020-08-25 8:34 ` [PR PATCH] [Updated] " mobinmob
2020-08-25 8:34 ` [PR REVIEW] " mobinmob
2020-08-25 8:46 ` mobinmob
2020-08-25 10:58 ` ahesford
2020-08-25 10:59 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824195958.zmDU-hLutUSLX_HtgJw51orrgXkD_du2i3ecRRvFyOE@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).