Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: julia: update to 1.5.0.
Date: Wed, 26 Aug 2020 04:30:14 +0200	[thread overview]
Message-ID: <20200826023014.AdhUQNvJsxrlNGWDoB91V9cscRdC3pSlq-lDonjtMDQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24097@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2921 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24097#issuecomment-680423238

Comment:
If you don't mind, please give me one more test. I can't put down `USE_SYSTEM_LLVM` and built one version with the Void `llvm10` and one with the in-tree, patched llvm9. I ran `xbps-src check julia` for each version. I've pushed a commit on top of your `p7zip` change to build with `USE_SYSTEM_LLVM`.

When built against Void `llvm10`, `check` reports 38552019 pass results, 3 failures, and 352559 broken tests.
When built with the in-tree llvm9, `check` reports 38559013 pass results, 3 failures and 352559 broken tests.

These are the differences:
```
--- llvm09.txt	2020-08-25 22:13:48.687994239 -0400
+++ llvm10.txt	2020-08-25 22:13:48.687994239 -0400
@@ -20,2 +19,2 @@
-    Libdl                           |       64             1        65
-    LinearAlgebra/addmul            |     4338                    4338
+    LinearAlgebra/addmul            |    10620                   10620
+    Libdl                           |       72             1        73
@@ -68 +67 @@
-    abstractarray                   |    54677         24795     79472
+    abstractarray                   |    54967         24795     79762
@@ -74 +73 @@
-    bitarray                        |   913624                  913624
+    bitarray                        |   914096                  914096
@@ -99 +98 @@
-    env                             |      191                     191
+    env                             |      192                     192
@@ -123 +122 @@
-    loading                         |   159280                  159280
+    loading                         |   145198                  145198
@@ -127 +126 @@
-    misc                            |  1280984                 1280984
+    misc                            |  1280992                 1280992
@@ -140 +139 @@
-    ranges                          | 12109662        327691  12437353
+    ranges                          | 12109689        327691  12437380
@@ -177 +176 @@
-  Overall                           | 38559013     3  352559  38911575
+  Overall                           | 38552019     3  352559  38904581
```

I'm not sure why the total number of tests is different, but it sure seems like Julia is generally doing what it expects with the Void `llvm10`.

If you can identify a problem caused by `llvm10`, we'll stick with the vendored version in https://github.com/void-linux/void-packages/pull/24097/commits/026635864dd593504e8f2a02d188a421685467e2 and call it quits. However, if everything seems to work as you expect with `llvm10`, I prefer building against the Void package. You've noted before that LLVM takes a long time to build, and builder resources are valuable. Adding all of this extra time just to support Julia is a hard sell unless absolutely necessary.

  parent reply	other threads:[~2020-08-26  2:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-06  2:50 [PR PATCH] " non-Jedi
2020-08-06 14:12 ` non-Jedi
2020-08-06 21:39 ` [PR PATCH] [Updated] " non-Jedi
2020-08-06 21:41 ` non-Jedi
2020-08-24  2:17 ` rjpower4
2020-08-24 18:41 ` non-Jedi
2020-08-25 14:56 ` ahesford
2020-08-25 15:01 ` [PR REVIEW] " ahesford
2020-08-25 15:25 ` ericonr
2020-08-25 16:33 ` [PR REVIEW] " non-Jedi
2020-08-25 19:22 ` [PR PATCH] [Updated] " ahesford
2020-08-25 19:26 ` ahesford
2020-08-25 19:53 ` [PR REVIEW] " non-Jedi
2020-08-25 19:53 ` non-Jedi
2020-08-25 19:53 ` non-Jedi
2020-08-25 19:56 ` non-Jedi
2020-08-25 19:59 ` non-Jedi
2020-08-25 20:00 ` non-Jedi
2020-08-25 20:04 ` ahesford
2020-08-25 20:05 ` ahesford
2020-08-25 20:09 ` ahesford
2020-08-25 20:09 ` ahesford
2020-08-25 20:18 ` non-Jedi
2020-08-25 20:20 ` non-Jedi
2020-08-25 20:21 ` non-Jedi
2020-08-25 20:29 ` non-Jedi
2020-08-25 20:47 ` ahesford
2020-08-25 21:32 ` [PR PATCH] [Updated] " ahesford
2020-08-25 21:33 ` ahesford
2020-08-26  1:58 ` [PR PATCH] [Updated] " non-Jedi
2020-08-26  2:00 ` non-Jedi
2020-08-26  2:03 ` [PR REVIEW] " non-Jedi
2020-08-26  2:14 ` non-Jedi
2020-08-26  2:30 ` [PR PATCH] [Updated] " ahesford
2020-08-26  2:30 ` ahesford [this message]
2020-08-26  2:44 ` [PR REVIEW] " ahesford
2020-08-26  2:46 ` non-Jedi
2020-08-26  2:52 ` ahesford
2020-08-26  2:56 ` non-Jedi
2020-08-26  2:57 ` non-Jedi
2020-08-26  4:06 ` [PR PATCH] [Closed]: " ahesford
2020-08-26  4:09 ` ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826023014.AdhUQNvJsxrlNGWDoB91V9cscRdC3pSlq-lDonjtMDQ@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).