From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Komikku: update dependencies
Date: Thu, 27 Aug 2020 16:15:13 +0200 [thread overview]
Message-ID: <20200827141513.LJQJk1YLro1EpiyBTHX5n6JbHMPstwjL3v_pvpnbp1c@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24463@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24463#issuecomment-681976441
Comment:
I don't use Komikku, but I'll note that the `komikku.servers` module does an unguarded `import keyring` and there are a lot of `komikku.servers` imports, so it looks like this is would be a minefield without `python3-keyring`. Also, the upstream flatpak pulls in `python3-keyring`. This seems to be the right call.
prev parent reply other threads:[~2020-08-27 14:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 13:30 [PR PATCH] " not-chicken
2020-08-25 13:43 ` sgn
2020-08-25 13:46 ` not-chicken
2020-08-25 13:59 ` sgn
2020-08-25 14:14 ` not-chicken
2020-08-25 14:35 ` sgn
2020-08-27 14:14 ` [PR PATCH] [Merged]: " ahesford
2020-08-27 14:15 ` ahesford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827141513.LJQJk1YLro1EpiyBTHX5n6JbHMPstwjL3v_pvpnbp1c@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).