From: hippi777 <hippi777@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] switch to functions for libc, atomic support, etc checks
Date: Sun, 30 Aug 2020 12:58:17 +0200 [thread overview]
Message-ID: <20200830105817.O5ha_qXy6hQToMSQiAuS20PaxqjzINf-JIoetv8VBTg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24539@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
New review comment by hippi777 on void-packages repository
https://github.com/void-linux/void-packages/pull/24539#discussion_r479715673
Comment:
this line is unnecessary, the same happens without it, just thats an implicit manner... also, why is the local libc if used only once? :D (note i didnt check for any conventions, so sorry if these are done to fullfill any)
next prev parent reply other threads:[~2020-08-30 10:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 2:49 [PR PATCH] [RFC] switch to functions for stuff like " ericonr
2020-08-30 9:51 ` [RFC] switch to functions for " fosslinux
2020-08-30 10:58 ` hippi777 [this message]
2020-08-30 14:43 ` [PR REVIEW] " ericonr
2020-08-30 14:45 ` ericonr
2020-08-30 17:10 ` q66
2020-08-30 23:08 ` fosslinux
2020-08-31 17:48 ` Duncaen
2020-08-31 17:59 ` [PR PATCH] [Closed]: " ericonr
2020-08-31 17:59 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200830105817.O5ha_qXy6hQToMSQiAuS20PaxqjzINf-JIoetv8VBTg@z \
--to=hippi777@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).