Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] sublime-merge: update to 2032.
Date: Thu, 03 Sep 2020 02:09:32 +0200	[thread overview]
Message-ID: <20200903000932.HYBNJmxn9NDr5G2e6gdvWcNkjF9OEtHUkiEiAv4gMH4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24620@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24620#discussion_r482608963

Comment:
Shouldn't this just use `vcopy`? Also, you're already in `$wrksrc` for `do_install`, no need to use absolute paths.
```
vcopy "*" opt/sublime_merge
```

  reply	other threads:[~2020-09-03  0:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 20:45 [PR PATCH] " mobinmob
2020-09-03  0:09 ` ahesford [this message]
2020-09-03 12:49 ` sgn
2020-09-03 13:44 ` ahesford
2020-09-03 19:40 ` mobinmob
2020-09-03 19:41 ` mobinmob
2020-09-04 13:29 ` ahesford
2020-09-04 21:03 ` [PR PATCH] [Updated] " mobinmob
2020-09-04 21:06 ` mobinmob
2020-09-05  7:17 ` [PR REVIEW] " Chocimier
2020-09-05  9:54 ` mobinmob
2020-09-05 11:29 ` ahesford
2020-09-05 11:49 ` [PR REVIEW] " ahesford
2020-09-05 13:27 ` Chocimier
2020-09-05 13:32 ` Chocimier
2020-09-05 15:48 ` [PR PATCH] [Updated] " mobinmob
2020-09-05 15:55 ` mobinmob
2020-09-29  2:23 ` ericonr
2020-09-29  2:36 ` ahesford
2020-09-29 18:15 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903000932.HYBNJmxn9NDr5G2e6gdvWcNkjF9OEtHUkiEiAv4gMH4@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).