Github messages for voidlinux
 help / color / mirror / Atom feed
From: CameronNemo <CameronNemo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: openldap: update to 2.4.53.
Date: Tue, 08 Sep 2020 04:16:27 +0200	[thread overview]
Message-ID: <20200908021627._xG-lXmA070IwzLSKzaFh2bLtEQ7fW8fVEKRCTNkvhQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24750@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24750#issuecomment-688575530

Comment:
Hello @ailiop-git,

This package appears to contain an example configuration file in /var that is a duplicate of one shipped in the /usr/share/examples directory.
Would you please verify that this example config is not needed and if so remove it (see patch below)?

Thanks,
Cameron

```diff
diff --git a/srcpkgs/openldap/INSTALL b/srcpkgs/openldap/INSTALL
index 386d43a645..20e8baba07 100644
--- a/srcpkgs/openldap/INSTALL
+++ b/srcpkgs/openldap/INSTALL
@@ -2,6 +2,5 @@
 case "$ACTION" in
 post)
 	chown ldap:ldap etc/openldap/slapd.conf
-	chown -R ldap:ldap var/lib/openldap
 	;;
 esac
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fb..2a67446611 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
 # Template file for 'openldap'
 pkgname=openldap
-version=2.4.52
+version=2.4.53
 revision=1
 build_style=gnu-configure
 configure_args="--prefix=/usr
@@ -20,10 +20,13 @@ conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
 short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="OLDAP-2.0"
-homepage="http://www.openldap.org"
+homepage="https://www.openldap.org"
 distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=035860e2fb812f2e294ea3e9914944691e4e4f52521b8945a5aacdcd088d8ae8
 
+make_dirs="
+ /var/lib/openldap 0755 ldap ldap
+ /var/lib/openldap/openldap-data 0755 ldap ldap"
 system_accounts="ldap"
 ldap_homedir="/var/lib/openldap"
 
@@ -41,6 +44,8 @@ post_install() {
 	vmkdir usr/share/examples/openldap
 	mv ${DESTDIR}/etc/openldap/*.{example,default} ${DESTDIR}/usr/share/examples/openldap
 	chmod 0644 ${DESTDIR}/usr/share/examples/openldap/*
+	# example file from above also duplicated in /var
+	rm -f -- "${DESTDIR}/var/lib/openldap/openldap-data/DB_CONFIG.example"
 }
 
 
```

  parent reply	other threads:[~2020-09-08  2:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 22:54 [PR PATCH] " ailiop-git
2020-09-08  2:02 ` CameronNemo
2020-09-08  2:03 ` CameronNemo
2020-09-08  2:16 ` CameronNemo [this message]
2020-09-08  6:14 ` ailiop-git
2020-10-17  9:51 ` [PR PATCH] [Updated] " ailiop-git
2020-10-31 20:01 ` ailiop-git
2020-11-15 18:44 ` ailiop-git
2020-11-15 19:02 ` ailiop-git
2021-02-15  5:03 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908021627._xG-lXmA070IwzLSKzaFh2bLtEQ7fW8fVEKRCTNkvhQ@z \
    --to=cameronnemo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).