* Re: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
@ 2020-09-08 2:02 ` CameronNemo
2020-09-08 2:03 ` CameronNemo
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-08 2:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/24750#issuecomment-688575530
Comment:
Hello @ailiop-git,
This package appears to contain an example configuration file in /var that is a duplicate of one shipped in the /usr/share/examples directory.
Would you please verify that this example config is not needed and if so remove it (see patch below)?
Thanks,
Cameron
```diff
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fb..d4b94825ad 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.53
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -20,10 +20,11 @@ conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="OLDAP-2.0"
-homepage="http://www.openldap.org"
+homepage="https://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=035860e2fb812f2e294ea3e9914944691e4e4f52521b8945a5aacdcd088d8ae8
+make_dirs="/var/lib/openldap/openldap-data 0755 root root"
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
@@ -40,6 +41,8 @@ post_install() {
chmod 755 ${DESTDIR}/usr/lib/*.so.*
vmkdir usr/share/examples/openldap
mv ${DESTDIR}/etc/openldap/*.{example,default} ${DESTDIR}/usr/share/examples/openldap
+ # example file from above also duplicated in /var
+ rm -f -- "${DESTDIR}/var/lib/openldap/openldap-data/DB_CONFIG.example"
chmod 0644 ${DESTDIR}/usr/share/examples/openldap/*
}
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
2020-09-08 2:02 ` CameronNemo
@ 2020-09-08 2:03 ` CameronNemo
2020-09-08 2:16 ` CameronNemo
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-08 2:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1827 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/24750#issuecomment-688575530
Comment:
Hello @ailiop-git,
This package appears to contain an example configuration file in /var that is a duplicate of one shipped in the /usr/share/examples directory.
Would you please verify that this example config is not needed and if so remove it (see patch below)?
Thanks,
Cameron
```diff
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fb..7ec9122cae 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.53
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -20,10 +20,11 @@ conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="OLDAP-2.0"
-homepage="http://www.openldap.org"
+homepage="https://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=035860e2fb812f2e294ea3e9914944691e4e4f52521b8945a5aacdcd088d8ae8
+make_dirs="/var/lib/openldap/openldap-data 0755 root root"
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
@@ -41,6 +42,8 @@ post_install() {
vmkdir usr/share/examples/openldap
mv ${DESTDIR}/etc/openldap/*.{example,default} ${DESTDIR}/usr/share/examples/openldap
chmod 0644 ${DESTDIR}/usr/share/examples/openldap/*
+ # example file from above also duplicated in /var
+ rm -f -- "${DESTDIR}/var/lib/openldap/openldap-data/DB_CONFIG.example"
}
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
2020-09-08 2:02 ` CameronNemo
2020-09-08 2:03 ` CameronNemo
@ 2020-09-08 2:16 ` CameronNemo
2020-09-08 6:14 ` ailiop-git
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-08 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/24750#issuecomment-688575530
Comment:
Hello @ailiop-git,
This package appears to contain an example configuration file in /var that is a duplicate of one shipped in the /usr/share/examples directory.
Would you please verify that this example config is not needed and if so remove it (see patch below)?
Thanks,
Cameron
```diff
diff --git a/srcpkgs/openldap/INSTALL b/srcpkgs/openldap/INSTALL
index 386d43a645..20e8baba07 100644
--- a/srcpkgs/openldap/INSTALL
+++ b/srcpkgs/openldap/INSTALL
@@ -2,6 +2,5 @@
case "$ACTION" in
post)
chown ldap:ldap etc/openldap/slapd.conf
- chown -R ldap:ldap var/lib/openldap
;;
esac
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fb..2a67446611 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.53
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -20,10 +20,13 @@ conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
maintainer="Orphaned <orphan@voidlinux.org>"
license="OLDAP-2.0"
-homepage="http://www.openldap.org"
+homepage="https://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=035860e2fb812f2e294ea3e9914944691e4e4f52521b8945a5aacdcd088d8ae8
+make_dirs="
+ /var/lib/openldap 0755 ldap ldap
+ /var/lib/openldap/openldap-data 0755 ldap ldap"
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
@@ -41,6 +44,8 @@ post_install() {
vmkdir usr/share/examples/openldap
mv ${DESTDIR}/etc/openldap/*.{example,default} ${DESTDIR}/usr/share/examples/openldap
chmod 0644 ${DESTDIR}/usr/share/examples/openldap/*
+ # example file from above also duplicated in /var
+ rm -f -- "${DESTDIR}/var/lib/openldap/openldap-data/DB_CONFIG.example"
}
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (2 preceding siblings ...)
2020-09-08 2:16 ` CameronNemo
@ 2020-09-08 6:14 ` ailiop-git
2020-10-17 9:51 ` [PR PATCH] [Updated] " ailiop-git
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ailiop-git @ 2020-09-08 6:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
New comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/pull/24750#issuecomment-688641856
Comment:
@CameronNemo yes that would work since the file needs to be renamed to "DB_CONFIG" for berkeleydb to open it.
That said, I'm not entirely sure it would be a good idea to remove it, since if anyone wants to customize this, it really needs to be in `/var/lib/openldap/openldap-data/` (or wherever slapd.conf ``directory`` directive points to) to take effect, and not in `/etc/openldap`, which can be confusing (especially since it will be silently ignored by bdb).
Also, note that the installer makefile intentionally places DB_CONFIG.example with 600 perms in `/var/lib/openldap/openldap-data/` while the one in the examples dir is world-readable. If anyone customizes this, after the first hurdle of discovering that it should placed in `/var/lib/openldap/openldap-data/` rather than `/etc/openldap`, will most certainly just copy it from the examples, and leave it world-readable. So this wouldn't be a good default.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (3 preceding siblings ...)
2020-09-08 6:14 ` ailiop-git
@ 2020-10-17 9:51 ` ailiop-git
2020-10-31 20:01 ` ailiop-git
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ailiop-git @ 2020-10-17 9:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
There is an updated pull request by ailiop-git against master on the void-packages repository
https://github.com/ailiop-git/void-packages openldap
https://github.com/void-linux/void-packages/pull/24750
openldap: update to 2.4.53.
A patch file from https://github.com/void-linux/void-packages/pull/24750.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openldap-24750.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From 4e4fb66c5097f710fc827a5473da6ddaf059df30 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sat, 17 Oct 2020 11:50:28 +0200
Subject: [PATCH] openldap: update to 2.4.54.
---
srcpkgs/openldap/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fbc..1931586af7f 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.54
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -18,11 +18,11 @@ makedepends="libressl-devel libsasl-devel db-devel libltdl-devel"
depends="openldap-tools>=${version}_${revision}"
conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Anthony Iliopoulos <ailiop@altatus.com>"
license="OLDAP-2.0"
homepage="http://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=a7ac148143ccfb04ea7e28d91bf6f98f08088e524d35bf86c11882dce1fb1a8f
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (4 preceding siblings ...)
2020-10-17 9:51 ` [PR PATCH] [Updated] " ailiop-git
@ 2020-10-31 20:01 ` ailiop-git
2020-11-15 18:44 ` ailiop-git
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ailiop-git @ 2020-10-31 20:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
There is an updated pull request by ailiop-git against master on the void-packages repository
https://github.com/ailiop-git/void-packages openldap
https://github.com/void-linux/void-packages/pull/24750
openldap: update to 2.4.53.
A patch file from https://github.com/void-linux/void-packages/pull/24750.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openldap-24750.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From a4a614af54cfad7133eea76a53c7dbd37197ee7b Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sat, 31 Oct 2020 21:01:08 +0100
Subject: [PATCH] openldap: update to 2.4.55.
---
srcpkgs/openldap/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fbc..1d627d8edf1 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.55
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -18,11 +18,11 @@ makedepends="libressl-devel libsasl-devel db-devel libltdl-devel"
depends="openldap-tools>=${version}_${revision}"
conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Anthony Iliopoulos <ailiop@altatus.com>"
license="OLDAP-2.0"
homepage="http://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=97357bd6ba8ff73d204c1f8208c5e6ab97d60c9e779f989057aa1229bbe98434
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (5 preceding siblings ...)
2020-10-31 20:01 ` ailiop-git
@ 2020-11-15 18:44 ` ailiop-git
2020-11-15 19:02 ` ailiop-git
2021-02-15 5:03 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ailiop-git @ 2020-11-15 18:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
There is an updated pull request by ailiop-git against master on the void-packages repository
https://github.com/ailiop-git/void-packages openldap
https://github.com/void-linux/void-packages/pull/24750
openldap: update to 2.4.53.
A patch file from https://github.com/void-linux/void-packages/pull/24750.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-openldap-24750.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From dff05dee4fe56de1e7e90f6739ae705862627f75 Mon Sep 17 00:00:00 2001
From: Anthony Iliopoulos <ailiop@altatus.com>
Date: Sun, 15 Nov 2020 19:43:58 +0100
Subject: [PATCH] openldap: update to 2.4.56.
---
srcpkgs/openldap/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/openldap/template b/srcpkgs/openldap/template
index ce708074fbc..c3524b1ee7f 100644
--- a/srcpkgs/openldap/template
+++ b/srcpkgs/openldap/template
@@ -1,6 +1,6 @@
# Template file for 'openldap'
pkgname=openldap
-version=2.4.52
+version=2.4.56
revision=1
build_style=gnu-configure
configure_args="--prefix=/usr
@@ -18,11 +18,11 @@ makedepends="libressl-devel libsasl-devel db-devel libltdl-devel"
depends="openldap-tools>=${version}_${revision}"
conf_files="/etc/openldap/ldap.conf /etc/openldap/slapd.conf"
short_desc="OpenLDAP (Lightweight Directory Access Protocol)"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Anthony Iliopoulos <ailiop@altatus.com>"
license="OLDAP-2.0"
homepage="http://www.openldap.org"
distfiles="https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-${version}.tgz"
-checksum=277b453f8e1593d759e6d6f4c8744f2042fa843e558f8e267f1c7890b8c35508
+checksum=25520e0363c93f3bcb89802a4aa3db33046206039436e0c7c9262db5a61115e0
system_accounts="ldap"
ldap_homedir="/var/lib/openldap"
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (6 preceding siblings ...)
2020-11-15 18:44 ` ailiop-git
@ 2020-11-15 19:02 ` ailiop-git
2021-02-15 5:03 ` [PR PATCH] [Merged]: " ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ailiop-git @ 2020-11-15 19:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/pull/24750#issuecomment-727619619
Comment:
can we get this merged please?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: openldap: update to 2.4.53.
2020-09-07 22:54 [PR PATCH] openldap: update to 2.4.53 ailiop-git
` (7 preceding siblings ...)
2020-11-15 19:02 ` ailiop-git
@ 2021-02-15 5:03 ` ericonr
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-02-15 5:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
There's a merged pull request on the void-packages repository
openldap: update to 2.4.53.
https://github.com/void-linux/void-packages/pull/24750
Description:
^ permalink raw reply [flat|nested] 10+ messages in thread