Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] sof-firmware: fix symlinks
@ 2020-09-09  7:42 PosaLusa24
  2020-09-11  4:53 ` cinerea0
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: PosaLusa24 @ 2020-09-09  7:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

There is a new pull request by PosaLusa24 against master on the void-packages repository

https://github.com/PosaLusa24/void-packages sof-firmware
https://github.com/void-linux/void-packages/pull/24776

sof-firmware: fix symlinks
Symlinks now point to .ri files in the intel-signed directory.

A patch file from https://github.com/void-linux/void-packages/pull/24776.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sof-firmware-24776.patch --]
[-- Type: text/x-diff, Size: 1828 bytes --]

From 834d618b3f7f6aed0bca87addf976ce283589f5b Mon Sep 17 00:00:00 2001
From: PosaLusa24 <posalusa24@gmail.com>
Date: Wed, 9 Sep 2020 14:10:39 +0630
Subject: [PATCH] sof-firmware: fix symlinks

Symlinks now point to .ri files in the intel-signed directory.
---
 srcpkgs/sof-firmware/template | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sof-firmware/template b/srcpkgs/sof-firmware/template
index 00dfd262191..39e218e12ec 100644
--- a/srcpkgs/sof-firmware/template
+++ b/srcpkgs/sof-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'sof-firmware'
 pkgname=sof-firmware
 version=1.5.1
-revision=1
+revision=2
 archs="i686* x86_64*"
 wrksrc=sof-bin-stable-v${version}
 short_desc="Sound Open Firmware and topology binaries"
@@ -22,12 +22,15 @@ do_install() {
 	for f in ${intel_path}/sof/v${version}/public-signed/*; do
 		vinstall ${f} 0644 /usr/${intel_path}/sof/public-signed
 	done
-	for arc in {bdw,byt,cht,apl,cnl,icl}; do
+	for arc in {bdw,byt,cht}; do
 		ln -s sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
 	done
-	ln -s sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
-	ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
-	ln -s sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
+	for arc in {apl,cnl,icl}; do
+		ln -s intel-signed/sof-${arc}-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-${arc}.ri
+	done
+	ln -s intel-signed/sof-apl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-glk.ri
+	ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cfl.ri
+	ln -s intel-signed/sof-cnl-v${version}.ri ${DESTDIR}/usr/${intel_path}/sof/sof-cml.ri
 	for f in ${intel_path}/sof-tplg-v${version}/*; do
 		vinstall ${f} 0644 /usr/${intel_path}/sof-tplg
 	done

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sof-firmware: fix symlinks
  2020-09-09  7:42 [PR PATCH] sof-firmware: fix symlinks PosaLusa24
@ 2020-09-11  4:53 ` cinerea0
  2020-09-11  5:22 ` PosaLusa24
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: cinerea0 @ 2020-09-11  4:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24776#issuecomment-690872609

Comment:
Pretty sure this is a duplicate of #24271.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sof-firmware: fix symlinks
  2020-09-09  7:42 [PR PATCH] sof-firmware: fix symlinks PosaLusa24
  2020-09-11  4:53 ` cinerea0
@ 2020-09-11  5:22 ` PosaLusa24
  2020-09-11 19:51 ` cinerea0
  2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: PosaLusa24 @ 2020-09-11  5:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New comment by PosaLusa24 on void-packages repository

https://github.com/void-linux/void-packages/pull/24776#issuecomment-690881100

Comment:
Thanks for the heads up! I did, in fact, see that PR. Seeing that a month has passed since it was active, I figured I would make a new one. Sorry if I wasn't supposed to; I'm still learning about collaboration on Github.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: sof-firmware: fix symlinks
  2020-09-09  7:42 [PR PATCH] sof-firmware: fix symlinks PosaLusa24
  2020-09-11  4:53 ` cinerea0
  2020-09-11  5:22 ` PosaLusa24
@ 2020-09-11 19:51 ` cinerea0
  2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: cinerea0 @ 2020-09-11 19:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/24776#issuecomment-691283403

Comment:
It's no problem, and I don't blame you for opening a new PR. I think the main reason that one hasn't been merged is because Gottox hasn't had the time to work on it. As long as you've incorporated the fixes discussed in that PR, this should be fine.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Closed]: sof-firmware: fix symlinks
  2020-09-09  7:42 [PR PATCH] sof-firmware: fix symlinks PosaLusa24
                   ` (2 preceding siblings ...)
  2020-09-11 19:51 ` cinerea0
@ 2020-12-10 18:48 ` ericonr
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-12-10 18:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

There's a closed pull request on the void-packages repository

sof-firmware: fix symlinks
https://github.com/void-linux/void-packages/pull/24776

Description:
Symlinks now point to .ri files in the intel-signed directory.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-10 18:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09  7:42 [PR PATCH] sof-firmware: fix symlinks PosaLusa24
2020-09-11  4:53 ` cinerea0
2020-09-11  5:22 ` PosaLusa24
2020-09-11 19:51 ` cinerea0
2020-12-10 18:48 ` [PR PATCH] [Closed]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).