[-- Attachment #1: Type: text/plain, Size: 395 bytes --] There is a new pull request by the-cleaner-66 against master on the void-packages repository https://github.com/the-cleaner-66/void-packages patch-3 https://github.com/void-linux/void-packages/pull/24840 Update template Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio) A patch file from https://github.com/void-linux/void-packages/pull/24840.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-patch-3-24840.patch --] [-- Type: text/x-diff, Size: 1357 bytes --] From 99c40c56b779948f7a9bc214b515c089a39fd23f Mon Sep 17 00:00:00 2001 From: the-cleaner-66 <71154788+the-cleaner-66@users.noreply.github.com> Date: Fri, 11 Sep 2020 23:57:05 +0200 Subject: [PATCH] Update template Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio) --- srcpkgs/virtualbox-ose/template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template index 23db4c7f963..86ede6fa592 100644 --- a/srcpkgs/virtualbox-ose/template +++ b/srcpkgs/virtualbox-ose/template @@ -1,15 +1,15 @@ # Template file for 'virtualbox-ose' pkgname=virtualbox-ose version=6.1.14 -revision=1 +revision=2 wrksrc="VirtualBox-${version%*a}" short_desc="General-purpose full virtualizer for x86 hardware" maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-2.0-only, CDDL-1.0" homepage="https://www.virtualbox.org" changelog="https://www.virtualbox.org/wiki/Changelog" -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" +checksum=16f3cb83ab3c4dacf2a9d3cc638cbd18db23767828bba6b8ba1c1b57abeb6aef nopie=yes lib32disabled=yes
[-- Attachment #1: Type: text/plain, Size: 245 bytes --] New review comment by Johnnynator on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487309889 Comment: Stay with $version and just append the `a` to the version string. And don't bump the revision.
[-- Attachment #1: Type: text/plain, Size: 164 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487320121 Comment: revision=1
[-- Attachment #1: Type: text/plain, Size: 250 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487320513 Comment: distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$versiona.tar.bz2"
[-- Attachment #1: Type: text/plain, Size: 273 bytes --] New review comment by fosslinux on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487336031 Comment: `distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"` to make it clearer, imo
[-- Attachment #1: Type: text/plain, Size: 188 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691362048 Comment: This PR should include the changes from #24838
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --] New comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407721 Comment: Thank you for the hints! I have one question: Where do I have to place the [ci skip] flag? Building the package took almost 60 minutes on my workstation laptop. Kind regards Michael Krahl Am Fri, 11 Sep 2020 15:01:45 -0700 schrieb John Zimmermann <notifications@github.com>: > @Johnnynator requested changes on this pull request. > > Use commit naming as outlined in > https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md > > > wrksrc="VirtualBox-${version%*a}" > short_desc="General-purpose full virtualizer for x86 hardware" > maintainer="Orphaned <orphan@voidlinux.org>" > license="GPL-2.0-only, CDDL-1.0" > homepage="https://www.virtualbox.org" > changelog="https://www.virtualbox.org/wiki/Changelog" > -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" > -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 > +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" > > Stay with $version and just append the `a` to the version string. And > don't bump the revision. > -- Michael Krahl Weiherstraße 16 D-89257 Illertissen Tel.: 07303-43726
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --] New comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407984 Comment: Perfect, thanks for your help! Kind regards Michael Krahl Am Fri, 11 Sep 2020 23:49:59 +0000 (UTC) schrieb fosslinux <notifications@github.com>: > @fosslinux commented on this pull request. > > > > > wrksrc="VirtualBox-${version%*a}" > short_desc="General-purpose full virtualizer for x86 hardware" > maintainer="Orphaned <orphan@voidlinux.org>" > license="GPL-2.0-only, CDDL-1.0" > homepage="https://www.virtualbox.org" > changelog="https://www.virtualbox.org/wiki/Changelog" > -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" > -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 > +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" > > `distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"` > to make it clearer, imo > -- Michael Krahl Weiherstraße 16 D-89257 Illertissen Tel.: 07303-43726
[-- Attachment #1: Type: text/plain, Size: 252 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487368782 Comment: distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"
[-- Attachment #1: Type: text/plain, Size: 156 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691438863 Comment: Working on it.
[-- Attachment #1: Type: text/plain, Size: 230 bytes --] There's a closed pull request on the void-packages repository Update template https://github.com/void-linux/void-packages/pull/24840 Description: Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio)
[-- Attachment #1: Type: text/plain, Size: 289 bytes --] New review comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/34519#discussion_r783360478 Comment: That's not how this works, rebase on top of our master, remove these CI changes and make sure to have only one commit with proper description.
[-- Attachment #1: Type: text/plain, Size: 155 bytes --] New review comment by zen0bit on void-packages repository https://github.com/void-linux/void-packages/pull/34519#discussion_r783701953 Comment: reverted