[-- Attachment #1: Type: text/plain, Size: 201 bytes --] New comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/20137#issuecomment-599604717 Comment: please follow the convention on how to format commit messages
[-- Attachment #1: Type: text/plain, Size: 395 bytes --] There is a new pull request by the-cleaner-66 against master on the void-packages repository https://github.com/the-cleaner-66/void-packages patch-3 https://github.com/void-linux/void-packages/pull/24840 Update template Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio) A patch file from https://github.com/void-linux/void-packages/pull/24840.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-patch-3-24840.patch --] [-- Type: text/x-diff, Size: 1357 bytes --] From 99c40c56b779948f7a9bc214b515c089a39fd23f Mon Sep 17 00:00:00 2001 From: the-cleaner-66 <71154788+the-cleaner-66@users.noreply.github.com> Date: Fri, 11 Sep 2020 23:57:05 +0200 Subject: [PATCH] Update template Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio) --- srcpkgs/virtualbox-ose/template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/srcpkgs/virtualbox-ose/template b/srcpkgs/virtualbox-ose/template index 23db4c7f963..86ede6fa592 100644 --- a/srcpkgs/virtualbox-ose/template +++ b/srcpkgs/virtualbox-ose/template @@ -1,15 +1,15 @@ # Template file for 'virtualbox-ose' pkgname=virtualbox-ose version=6.1.14 -revision=1 +revision=2 wrksrc="VirtualBox-${version%*a}" short_desc="General-purpose full virtualizer for x86 hardware" maintainer="Orphaned <orphan@voidlinux.org>" license="GPL-2.0-only, CDDL-1.0" homepage="https://www.virtualbox.org" changelog="https://www.virtualbox.org/wiki/Changelog" -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" +checksum=16f3cb83ab3c4dacf2a9d3cc638cbd18db23767828bba6b8ba1c1b57abeb6aef nopie=yes lib32disabled=yes
[-- Attachment #1: Type: text/plain, Size: 245 bytes --] New review comment by Johnnynator on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487309889 Comment: Stay with $version and just append the `a` to the version string. And don't bump the revision.
[-- Attachment #1: Type: text/plain, Size: 164 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487320121 Comment: revision=1
[-- Attachment #1: Type: text/plain, Size: 250 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487320513 Comment: distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$versiona.tar.bz2"
[-- Attachment #1: Type: text/plain, Size: 273 bytes --] New review comment by fosslinux on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487336031 Comment: `distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"` to make it clearer, imo
[-- Attachment #1: Type: text/plain, Size: 188 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691362048 Comment: This PR should include the changes from #24838
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --] New comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407721 Comment: Thank you for the hints! I have one question: Where do I have to place the [ci skip] flag? Building the package took almost 60 minutes on my workstation laptop. Kind regards Michael Krahl Am Fri, 11 Sep 2020 15:01:45 -0700 schrieb John Zimmermann <notifications@github.com>: > @Johnnynator requested changes on this pull request. > > Use commit naming as outlined in > https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md > > > wrksrc="VirtualBox-${version%*a}" > short_desc="General-purpose full virtualizer for x86 hardware" > maintainer="Orphaned <orphan@voidlinux.org>" > license="GPL-2.0-only, CDDL-1.0" > homepage="https://www.virtualbox.org" > changelog="https://www.virtualbox.org/wiki/Changelog" > -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" > -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 > +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" > > Stay with $version and just append the `a` to the version string. And > don't bump the revision. > -- Michael Krahl Weiherstraße 16 D-89257 Illertissen Tel.: 07303-43726
[-- Attachment #1: Type: text/plain, Size: 1121 bytes --] New comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691407984 Comment: Perfect, thanks for your help! Kind regards Michael Krahl Am Fri, 11 Sep 2020 23:49:59 +0000 (UTC) schrieb fosslinux <notifications@github.com>: > @fosslinux commented on this pull request. > > > > > wrksrc="VirtualBox-${version%*a}" > short_desc="General-purpose full virtualizer for x86 hardware" > maintainer="Orphaned <orphan@voidlinux.org>" > license="GPL-2.0-only, CDDL-1.0" > homepage="https://www.virtualbox.org" > changelog="https://www.virtualbox.org/wiki/Changelog" > -distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-$version.tar.bz2" > -checksum=91fa05bcfce36316ca93e3927c9550ea66286fff4c5bec900b753fca278ce1a0 > +distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-6.1.14a.tar.bz2" > > `distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"` > to make it clearer, imo > -- Michael Krahl Weiherstraße 16 D-89257 Illertissen Tel.: 07303-43726
[-- Attachment #1: Type: text/plain, Size: 252 bytes --] New review comment by the-cleaner-66 on void-packages repository https://github.com/void-linux/void-packages/pull/24840#discussion_r487368782 Comment: distfiles="http://download.virtualbox.org/virtualbox/${version%*a}/VirtualBox-${version}a.tar.bz2"
[-- Attachment #1: Type: text/plain, Size: 156 bytes --] New comment by pullmoll on void-packages repository https://github.com/void-linux/void-packages/pull/24840#issuecomment-691438863 Comment: Working on it.
[-- Attachment #1: Type: text/plain, Size: 230 bytes --] There's a closed pull request on the void-packages repository Update template https://github.com/void-linux/void-packages/pull/24840 Description: Newer "distfiles" (date: 07.09.2020) + modified "LocalConfig.kmk" (enable virtio)
[-- Attachment #1: Type: text/plain, Size: 202 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/30568#issuecomment-828832311 Comment: Please use the correct commit message `gradle: update to 7.0`
[-- Attachment #1: Type: text/plain, Size: 616 bytes --] New comment by FollieHiyuki on void-packages repository https://github.com/void-linux/void-packages/pull/30568#issuecomment-828870056 Comment: Please squash all your commits into 1 with message `gradle: update to 7.0`. And don't do all the `wget` and `unzip` ... inside the template, `xbps-src` will handle that. This is not really an installer script either so drop the last line with `do_install` call as well. Anyways you can always re-read the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md) and checkout templates for other packages to know how to properly write a template.
[-- Attachment #1: Type: text/plain, Size: 836 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/30568#issuecomment-829300746 Comment: I believe there is a misunderstanding here... A template isn't a script that installs a given piece of software on your system, it's instead supposed to be used to create a package (a compressed tarball), which is what the package manager (xbps) will use to install the software. The template did this correctly, but your changes seem to be moving in the direction of making it a script. If you look at the README, you will see that templates aren't supposed to be run directly, but instead that you're supposed to run `./xbps-src pkg gradle` and this will create a gradle package inside `hostdir/binpkgs/` which you can install using `xi gradle` (`xi` being a script from the `xtools` package).
[-- Attachment #1: Type: text/plain, Size: 191 bytes --] New comment by q66 on void-packages repository https://github.com/void-linux/void-packages/pull/30680#issuecomment-832175465 Comment: fix commit message, also the URL shouldn't be replaced
[-- Attachment #1: Type: text/plain, Size: 188 bytes --] New comment by ericonr on void-packages repository https://github.com/void-linux/void-packages/pull/30568#issuecomment-841965575 Comment: Closing due to inactivity. Feel free to reopen!
[-- Attachment #1: Type: text/plain, Size: 323 bytes --] New comment by Duncaen on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-993531766 Comment: 1. You don't have to reopen PRs, force push to the branch instead of spamming new PRs. 2. Switching maintainer and upstream to your own without any reason/input/comment seems weird.
[-- Attachment #1: Type: text/plain, Size: 522 bytes --] New comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013071032 Comment: I looked at your fork and it is only one commit ahead of the archived upstream - https://github.com/oSoWoSo/clearine/commit/a59184e0e7c9ed49437c255e37944457bf531690. The commit description is useless, is this fixing a bug? Could you describe it? If it is, I think we should just include patch in this repository and not change the upstream. cc @steinex - the package maintainer
[-- Attachment #1: Type: text/plain, Size: 260 bytes --] New comment by zen0bit on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013371882 Comment: I am already trying... First try here https://github.com/oSoWoSo/void-packages/tree/clearine-patch Not tested yet
[-- Attachment #1: Type: text/plain, Size: 396 bytes --] New comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1013505004 Comment: Please test the changes on your computer first, verify that git log shows what you expect and then force push here. > The commit description is useless, is this fixing a bug? Could you describe it? Could you describe what are you trying to achieve?
[-- Attachment #1: Type: text/plain, Size: 198 bytes --] New comment by zen0bit on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025166819 Comment: I cannot build it anymore even from official template...
[-- Attachment #1: Type: text/plain, Size: 459 bytes --] New comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025185463 Comment: ``` >>> a = "123" >>> a is "123" <stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="? True >>> a == "123" True ``` So this PR is not fixing anything other than syntax warnings, if I am wrong, please leave a comment. I asked multiple times what this PR is supposed to fix, but you didn't respond.
[-- Attachment #1: Type: text/plain, Size: 145 bytes --] New comment by zen0bit on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025192898 Comment: Yes
[-- Attachment #1: Type: text/plain, Size: 449 bytes --] New comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/34519#issuecomment-1025192936 Comment: > ``` > >>> a = "123" > >>> a is "123" > <stdin>:1: SyntaxWarning: "is" with a literal. Did you mean "=="? > True > >>> a == "123" > True > ``` This actually works only in some cases, if you describe what is actually happening, what is the bug and how can we reproduce this, we can reopen this PR.
[-- Attachment #1: Type: text/plain, Size: 604 bytes --] New comment by abenson on void-packages repository https://github.com/void-linux/void-packages/pull/46429#issuecomment-1746867959 Comment: Please update the commit message to following [convention](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#committing-your-changes). It should say: `kodi-addon-inputstream-adaptive: update to 19.0.7.` You can edit your commit message by amending the commit: $ git commit --amend This will open an editor allowing you to edit the commit message, then save and quit. Next, force push to your branch. $ git push -f