Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Update LocalConfig.kmk
@ 2020-09-11 21:44 the-cleaner-66
  2020-09-12  0:12 ` ericonr
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: the-cleaner-66 @ 2020-09-11 21:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

There is a new pull request by the-cleaner-66 against master on the void-packages repository

https://github.com/the-cleaner-66/void-packages patch-2
https://github.com/void-linux/void-packages/pull/24838

Update LocalConfig.kmk
"VBOX_WITH_VIRTIO = 1" to add virtio-net (Paravirtualized Network)

A patch file from https://github.com/void-linux/void-packages/pull/24838.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-24838.patch --]
[-- Type: text/x-diff, Size: 930 bytes --]

From fe2137ad8769855bf7ae030630af52a35db5d112 Mon Sep 17 00:00:00 2001
From: the-cleaner-66 <71154788+the-cleaner-66@users.noreply.github.com>
Date: Fri, 11 Sep 2020 23:41:56 +0200
Subject: [PATCH] Update LocalConfig.kmk

"VBOX_WITH_VIRTIO = 1" to add virtio-net (Paravirtualized Network)
---
 srcpkgs/virtualbox-ose/files/LocalConfig.kmk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/virtualbox-ose/files/LocalConfig.kmk b/srcpkgs/virtualbox-ose/files/LocalConfig.kmk
index 4f5dcab41b8..71ffd9876c0 100644
--- a/srcpkgs/virtualbox-ose/files/LocalConfig.kmk
+++ b/srcpkgs/virtualbox-ose/files/LocalConfig.kmk
@@ -4,7 +4,7 @@ VBOX_WITH_LINUX_ADDITIONS = 1
 VBOX_WITH_X11_ADDITIONS = 1
 VBOX_WITH_TESTCASES =
 VBOX_WITH_TESTSUITE =
-VBOX_WITH_VIRTIO =
+VBOX_WITH_VIRTIO = 1
 VBOX_WITH_ORIGIN :=
 VBOX_PATH_APP_PRIVATE_ARCH := /usr/lib/virtualbox
 VBOX_PATH_SHARED_LIBS := $(VBOX_PATH_APP_PRIVATE_ARCH)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Update LocalConfig.kmk
  2020-09-11 21:44 [PR PATCH] Update LocalConfig.kmk the-cleaner-66
@ 2020-09-12  0:12 ` ericonr
  2020-09-12  7:03 ` [PR PATCH] [Closed]: " pullmoll
  2020-09-12  7:03 ` pullmoll
  2 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-09-12  0:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24838#issuecomment-691361559

Comment:
Please follow the commit style: `virtualbox-ose: enable virtio-net.`

You need to revbump the package as well, otherwise it won't be rebuilt.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Update LocalConfig.kmk
  2020-09-11 21:44 [PR PATCH] Update LocalConfig.kmk the-cleaner-66
  2020-09-12  0:12 ` ericonr
  2020-09-12  7:03 ` [PR PATCH] [Closed]: " pullmoll
@ 2020-09-12  7:03 ` pullmoll
  2 siblings, 0 replies; 4+ messages in thread
From: pullmoll @ 2020-09-12  7:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24838#issuecomment-691430171

Comment:
This does not work, which is why I added `VBOX_WITH_VIRTIO =` in the first place.
The current release lacks some files required to build with virtio:
```
kmk: *** No rule to make target '/builddir/VirtualBox-6.1.14/src/VBox/Devices/VirtIO/VirtioCore.cpp', needed
 by '/builddir/VirtualBox-6.1.14/out/linux.amd64/release/obj/VBoxDD/VirtIO/VirtioCore.o'.  Stop.
```
BTW: it doesn't help to import these files from their repository. They don't compile.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: Update LocalConfig.kmk
  2020-09-11 21:44 [PR PATCH] Update LocalConfig.kmk the-cleaner-66
  2020-09-12  0:12 ` ericonr
@ 2020-09-12  7:03 ` pullmoll
  2020-09-12  7:03 ` pullmoll
  2 siblings, 0 replies; 4+ messages in thread
From: pullmoll @ 2020-09-12  7:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

There's a closed pull request on the void-packages repository

Update LocalConfig.kmk
https://github.com/void-linux/void-packages/pull/24838

Description:
"VBOX_WITH_VIRTIO = 1" to add virtio-net (Paravirtualized Network)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-12  7:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 21:44 [PR PATCH] Update LocalConfig.kmk the-cleaner-66
2020-09-12  0:12 ` ericonr
2020-09-12  7:03 ` [PR PATCH] [Closed]: " pullmoll
2020-09-12  7:03 ` pullmoll

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).