* Re: [PR REVIEW] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
@ 2020-09-13 0:54 ` sgn
2020-09-13 10:48 ` sgn
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2020-09-13 0:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#discussion_r487465132
Comment:
I prefer to keep them for no reason.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
2020-09-13 0:54 ` [PR REVIEW] " sgn
@ 2020-09-13 10:48 ` sgn
2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2020-09-13 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#discussion_r487465132
Comment:
I prefer to keep them (for no reason).
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
2020-09-13 0:54 ` [PR REVIEW] " sgn
2020-09-13 10:48 ` sgn
@ 2020-09-15 16:11 ` CameronNemo
2020-09-15 18:46 ` [PR REVIEW] " Piraty
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-15 16:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
There is an updated pull request by CameronNemo against master on the void-packages repository
https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867
dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.
A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1422 bytes --]
From 3a41ab6ca12a79100dfed6fe2f41f2379e9499fa Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option
---
srcpkgs/dhcpcd/template | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..f01d260a1d6 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,10 @@
# Template file for 'dhcpcd'
pkgname=dhcpcd
version=9.2.0
-revision=1
+revision=2
build_style=configure
make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd"
hostmakedepends="ntp pkg-config"
makedepends="eudev-libudev-devel"
short_desc="RFC2131 compliant DHCP client"
@@ -15,10 +15,17 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
lib32disabled=yes
conf_files=/etc/dhcpcd.conf
-# privsep
+
system_accounts="_dhcpcd"
_dhcpcd_homedir="/var/db/dhcpcd"
+build_options="privsep"
+build_options_default="privsep"
+
+if [ "$build_option_privsep" ]; then
+ configure_args+=" --privsepuser=_dhcpcd"
+fi
+
post_install() {
vsv dhcpcd
vsv dhcpcd-eth0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (2 preceding siblings ...)
2020-09-15 16:11 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-09-15 18:46 ` Piraty
2020-09-21 0:34 ` CameronNemo
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Piraty @ 2020-09-15 18:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#discussion_r488886569
Comment:
`vopt_if`?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (3 preceding siblings ...)
2020-09-15 18:46 ` [PR REVIEW] " Piraty
@ 2020-09-21 0:34 ` CameronNemo
2020-09-21 0:35 ` [PR PATCH] [Updated] " CameronNemo
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-21 0:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#discussion_r491754563
Comment:
kept
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (4 preceding siblings ...)
2020-09-21 0:34 ` CameronNemo
@ 2020-09-21 0:35 ` CameronNemo
2020-09-21 0:35 ` [PR REVIEW] " CameronNemo
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-21 0:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
There is an updated pull request by CameronNemo against master on the void-packages repository
https://github.com/CameronNemo/void-packages dhcpcd-privsep-option
https://github.com/void-linux/void-packages/pull/24867
dhcpcd: make privsep a build option
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.
A patch file from https://github.com/void-linux/void-packages/pull/24867.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dhcpcd-privsep-option-24867.patch --]
[-- Type: text/x-diff, Size: 1378 bytes --]
From a6901b09b77cfc2c7328540fbccc271756bb1b8e Mon Sep 17 00:00:00 2001
From: Cameron Nemo <cnemo@tutanota.com>
Date: Sat, 12 Sep 2020 11:38:57 -0700
Subject: [PATCH] dhcpcd: make privsep a build option
---
srcpkgs/dhcpcd/template | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/dhcpcd/template b/srcpkgs/dhcpcd/template
index 89da9d503bf..6f015e19514 100644
--- a/srcpkgs/dhcpcd/template
+++ b/srcpkgs/dhcpcd/template
@@ -1,10 +1,12 @@
# Template file for 'dhcpcd'
pkgname=dhcpcd
version=9.2.0
-revision=1
+revision=2
build_style=configure
make_check_target=test
-configure_args="--prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd --privsepuser=_dhcpcd"
+configure_args="
+ --prefix=/usr --sbindir=/usr/bin --sysconfdir=/etc --rundir=/run/dhcpcd
+ $(vopt_if privsep --privsepuser=_dhcpcd)"
hostmakedepends="ntp pkg-config"
makedepends="eudev-libudev-devel"
short_desc="RFC2131 compliant DHCP client"
@@ -15,10 +17,13 @@ distfiles="https://roy.marples.name/downloads/dhcpcd/dhcpcd-${version}.tar.xz"
checksum=fcb2d19672d445bbfd38678fdee4f556ef967a3ea6bd81092d10545df2cb9666
lib32disabled=yes
conf_files=/etc/dhcpcd.conf
-# privsep
+
system_accounts="_dhcpcd"
_dhcpcd_homedir="/var/db/dhcpcd"
+build_options="privsep"
+build_options_default="privsep"
+
post_install() {
vsv dhcpcd
vsv dhcpcd-eth0
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (5 preceding siblings ...)
2020-09-21 0:35 ` [PR PATCH] [Updated] " CameronNemo
@ 2020-09-21 0:35 ` CameronNemo
2020-09-23 9:54 ` the-maldridge
2020-10-15 14:43 ` [PR PATCH] [Closed]: " CameronNemo
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-09-21 0:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#discussion_r491754716
Comment:
used vopt_if
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (6 preceding siblings ...)
2020-09-21 0:35 ` [PR REVIEW] " CameronNemo
@ 2020-09-23 9:54 ` the-maldridge
2020-10-15 14:43 ` [PR PATCH] [Closed]: " CameronNemo
8 siblings, 0 replies; 10+ messages in thread
From: the-maldridge @ 2020-09-23 9:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/24867#issuecomment-697260425
Comment:
This doesn't really solve the original problem though, which is it forking away from the supervisor. I'm not sure why you'd add this package since it doesn't change the status of the bug that needs to be fixed.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Closed]: dhcpcd: make privsep a build option
2020-09-12 18:40 [PR PATCH] dhcpcd: make privsep a build option CameronNemo
` (7 preceding siblings ...)
2020-09-23 9:54 ` the-maldridge
@ 2020-10-15 14:43 ` CameronNemo
8 siblings, 0 replies; 10+ messages in thread
From: CameronNemo @ 2020-10-15 14:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
There's a closed pull request on the void-packages repository
dhcpcd: make privsep a build option
https://github.com/void-linux/void-packages/pull/24867
Description:
Still forks away from the supervisor :/
But there is no huge process tree, just a launcher and master.
^ permalink raw reply [flat|nested] 10+ messages in thread