Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] dovecot: fix size of time_t for 64-bit cross.
Date: Wed, 16 Sep 2020 02:20:20 +0200	[thread overview]
Message-ID: <20200916002020.cI16jxFds3JI2Hl2vQ_PSk1gcHuLnd4Feo4y8Hc7dYM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24934@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages dove
https://github.com/void-linux/void-packages/pull/24934

dovecot: fix size of time_t for 64-bit cross.
configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.

A patch file from https://github.com/void-linux/void-packages/pull/24934.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dove-24934.patch --]
[-- Type: text/x-diff, Size: 1735 bytes --]

From 2bd0735d68aa5e1e8e814acb58e03feedef073ec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Tue, 15 Sep 2020 21:12:15 -0300
Subject: [PATCH] dovecot: fix size of time_t for 64-bit cross.

configure_args hard coded the size of the time_t type, which means
64-bit cross compiled archs, such as aarch64, were using the wrong type.
For little-endian, it would just break 2038-proofness, but BE machines
could have bigger issues.

A comment and commented out code were added to prepare for musl's time64
update.
---
 srcpkgs/dovecot/template | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/dovecot/template b/srcpkgs/dovecot/template
index 03501d0aebf..6c2ad93efd4 100644
--- a/srcpkgs/dovecot/template
+++ b/srcpkgs/dovecot/template
@@ -2,7 +2,7 @@
 # revbump dovecot-plugin-pigeonhole when updating dovecot!
 pkgname=dovecot
 version=2.3.11.3
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--with-moduledir=/usr/lib/dovecot/modules --with-sql=plugin
  --disable-static --with-pam --with-mysql --with-pgsql --with-lucene
@@ -22,14 +22,16 @@ distfiles="${homepage}/releases/2.3/${pkgname}-${version}.tar.gz"
 checksum=d3d9ea9010277f57eb5b9f4166a5d2ba539b172bd6d5a2b2529a6db524baafdc
 keep_libtool_archives=yes
 
-
 if [ "$CROSS_BUILD" ]; then
+	_tsize=${XBPS_TARGET_WORDSIZE}
+	# FIXME: remove for time64 rebuild
+	#[ "$XBPS_TARGET_LIBC" = "musl" ] && _tsize=64
 	configure_args+="
 		i_cv_epoll_works=yes
 		i_cv_inotify_works=yes
 		i_cv_posix_fallocate_works=yes
 		i_cv_signed_size_t=no
-		i_cv_gmtime_max_time_t=32
+		i_cv_gmtime_max_time_t=${_tsize}
 		i_cv_signed_time_t=yes
 		i_cv_mmap_plays_with_write=yes
 		i_cv_fd_passing=yes

  reply	other threads:[~2020-09-16  0:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  0:19 [PR PATCH] " ericonr
2020-09-16  0:20 ` ericonr [this message]
2020-09-16  0:22 ` ericonr
2020-09-16  0:28 ` q66
2020-09-16  9:13 ` leahneukirchen
2020-09-16 12:02 ` [PR PATCH] [Updated] " ericonr
2020-09-16 12:06 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916002020.cI16jxFds3JI2Hl2vQ_PSk1gcHuLnd4Feo4y8Hc7dYM@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).